You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/08/11 15:20:37 UTC

[GitHub] [pulsar] nlu90 commented on pull request #11468: [Function worker] Load ServiceConfiguration from file, not from Worke…

nlu90 commented on pull request #11468:
URL: https://github.com/apache/pulsar/pull/11468#issuecomment-896918266


   > > How about add the missing fields into the `WorkerConfig`?
   > 
   > @nlu90 - this isn't an option because the fields are for extensions created by users. Note that the `ServiceConfigruation` already has a map for arbitrary config. The `WorkerConfig` does not have this map. An alternate solution could instead add the map to the `WorkerConfig`, but I'm not sure how that would impact a function worker's runtime.
   
   I'm in favor of adding this map into `WorkerConfig` instead of introducing a second configuration. If you can point out specifically which field is missing, we can take a close look at the impact.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org