[PR] Remove fanout publisher sink wrapper [pekko]

["He-Pin (via GitHub)" <gi...@apache.org>]

He-Pin opened a new pull request, #3176:
URL: https://github.com/apache/pekko/pull/3176

   ### Motivation
   Refs #2860 tracks converting old stream internals to GraphStages. After the fanout publisher runtime moved to `FanoutPublisherBridgeStage`, `Sink.asPublisher(fanout = true)` still kept `FanoutPublisherSink` as an internal `SinkModule` wrapper.
   
   ### Modification
   - Build the fanout publisher sink directly from `Flow[T].async` and `FanoutPublisherBridgeStage`.
   - Delete the remaining `FanoutPublisherSink` wrapper.
   - Add a MiMa filter for the removed internal class.
   
   ### Result
   The fanout publisher path now composes directly from the GraphStage bridge while preserving the async/request boundary covered by the existing fanout and FlowSpec tests. The public `Sink.asPublisher` API is unchanged.
   
   ### Tests
   - `rtk env JAVA_HOME=/Users/hepin/Library/Java/JavaVirtualMachines/azul-17.0.17/Contents/Home PATH=/Users/hepin/Library/Java/JavaVirtualMachines/azul-17.0.17/Contents/Home/bin:$PATH sbt "stream-tests / Test / testOnly org.apache.pekko.stream.impl.FanoutPublisherBehaviorSpec"` - passed
   - `rtk env JAVA_HOME=/Users/hepin/Library/Java/JavaVirtualMachines/azul-17.0.17/Contents/Home PATH=/Users/hepin/Library/Java/JavaVirtualMachines/azul-17.0.17/Contents/Home/bin:$PATH sbt "stream-tests / Test / testOnly org.apache.pekko.stream.scaladsl.PublisherSinkSpec org.apache.pekko.stream.scaladsl.SinkSpec org.apache.pekko.stream.scaladsl.FlowSpec org.apache.pekko.stream.impl.TimeoutsSpec"` - passed
   - `rtk env JAVA_HOME=/Users/hepin/Library/Java/JavaVirtualMachines/azul-17.0.17/Contents/Home PATH=/Users/hepin/Library/Java/JavaVirtualMachines/azul-17.0.17/Contents/Home/bin:$PATH sbt "stream-tests-tck / Test / testOnly org.apache.pekko.stream.tck.FanoutPublisherTest"` - passed
   - `rtk env JAVA_HOME=/Users/hepin/Library/Java/JavaVirtualMachines/azul-17.0.17/Contents/Home PATH=/Users/hepin/Library/Java/JavaVirtualMachines/azul-17.0.17/Contents/Home/bin:$PATH sbt "stream / mimaReportBinaryIssues"` - passed
   - `rtk env JAVA_HOME=/Users/hepin/Library/Java/JavaVirtualMachines/azul-17.0.17/Contents/Home PATH=/Users/hepin/Library/Java/JavaVirtualMachines/azul-17.0.17/Contents/Home/bin:$PATH sbt headerCreateAll` - passed
   - `rtk env JAVA_HOME=/Users/hepin/Library/Java/JavaVirtualMachines/azul-17.0.17/Contents/Home PATH=/Users/hepin/Library/Java/JavaVirtualMachines/azul-17.0.17/Contents/Home/bin:$PATH sbt "+headerCheckAll"` - passed
   - `rtk scalafmt --list --mode diff-ref=origin/main` - passed
   - `rtk git diff --check` - passed
   - Qoder stdout review with `/tmp/project-review.diff` attachment - No must-fix findings (`/tmp/project-qoder-review.log`)
   
   ### References
   Refs #2860


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org

Re: [PR] Remove fanout publisher sink wrapper [pekko]

["He-Pin (via GitHub)" <gi...@apache.org>]

He-Pin merged PR #3176:
URL: https://github.com/apache/pekko/pull/3176


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org