You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tuweni.apache.org by Antoine Toulme <an...@toulme.name> on 2020/05/10 06:13:08 UTC

[VOTE] Tuweni 1.1.0-incubating release

We're voting on the source distributions available here:
https://dist.apache.org/repos/dist/dev/incubator/tuweni/1.1.0-incubating/
The release tag is present here:
https://github.com/apache/incubator-tuweni/releases/tag/v1.1.0-incubating

This release includes the following changes:

New:
* Implement DNS discovery reader, reading from goerli and mainnet
* Implement #71 - short hash string
* Implement #72 - Upgrade codec dependency by @ajsutton 
* #74 and #75 enhance UInt256 performance by @shemnon

Changes:
* Move to slf4j from logl
* Simplify address and hash classes
* Expose the ability to destroy public keys directly

Bug fixes:
* Fix for issue #50 - FileBackedFingerprintRepository throws NPE if fingerPrintFile has no parent Dir
* Fix for issue #78 - Dist tar.gz and zip contain duplicate items
* Fix for issue #82 - Fix Windows tests by @shemnon

Misc:
* Adopt github actions to run CI
* Upgrade to Gradle 6.3
* Fix for issue #63 docker to build

Cheers,

Antoine
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org


[RESULT][VOTE] Tuweni 1.1.0-incubating release

Posted by Antoine Toulme <an...@toulme.name>.
The release vote has completed.

Here are the votes:
3 +1:
Rob Dawson
Furkan Kamaci
Antoine Toulme
0 +0
0 -1

The release vote has passed. The release will now proceed to the general incubator list for an IPMC vote.

Cheers,

Antoine

> On May 18, 2020, at 8:59 PM, Antoine Toulme <an...@toulme.name> wrote:
> 
> Here is my +1.
> 
>> On May 13, 2020, at 3:53 PM, Furkan KAMACI <fu...@gmail.com> wrote:
>> 
>> Hi Antoine,
>> 
>> I can file a bug for it (it may specific to my environment) and we can
>> check it for the next release.
>> 
>> Kind Regards,
>> Furkan KAMACI
>> 
>> On Thu, May 14, 2020 at 1:49 AM Antoine Toulme <an...@toulme.name> wrote:
>> 
>>> Should I make the build work with the src dist? File a bug and look at it
>>> next release? What’s the requirement there, so I can know what to do?
>>> 
>>>> On May 13, 2020, at 3:41 PM, Furkan KAMACI <fu...@gmail.com>
>>> wrote:
>>>> 
>>>> Hi,
>>>> 
>>>> +1 from me.
>>>> 
>>>> I checked:
>>>> 
>>>> - Incubating in name
>>>> - DISCLAIMER exists
>>>> - LICENSE and NOTICE are fine
>>>> - No unexpected binary files
>>>> - Checked PGP signatures
>>>> - Checked Checksums
>>>> - Code compiles and tests successfully run
>>>> 
>>>> PS: I couldn't build the project from src dist. I've downloaded it from
>>>> GitHub tag.
>>>> 
>>>> Kind Regards,
>>>> Furkan KAMACI
>>>> 
>>>> On Thu, May 14, 2020 at 12:29 AM Rob Dawson <ro...@apache.org> wrote:
>>>> 
>>>>> +1. Didn't get a chance to test it
>>>>> 
>>>>> On 2020/05/10 06:13:08, Antoine Toulme <an...@toulme.name> wrote:
>>>>>> We're voting on the source distributions available here:
>>>>>> 
>>>>> 
>>> https://dist.apache.org/repos/dist/dev/incubator/tuweni/1.1.0-incubating/
>>>>>> The release tag is present here:
>>>>>> 
>>>>> 
>>> https://github.com/apache/incubator-tuweni/releases/tag/v1.1.0-incubating
>>>>>> 
>>>>>> This release includes the following changes:
>>>>>> 
>>>>>> New:
>>>>>> * Implement DNS discovery reader, reading from goerli and mainnet
>>>>>> * Implement #71 - short hash string
>>>>>> * Implement #72 - Upgrade codec dependency by @ajsutton
>>>>>> * #74 and #75 enhance UInt256 performance by @shemnon
>>>>>> 
>>>>>> Changes:
>>>>>> * Move to slf4j from logl
>>>>>> * Simplify address and hash classes
>>>>>> * Expose the ability to destroy public keys directly
>>>>>> 
>>>>>> Bug fixes:
>>>>>> * Fix for issue #50 - FileBackedFingerprintRepository throws NPE if
>>>>> fingerPrintFile has no parent Dir
>>>>>> * Fix for issue #78 - Dist tar.gz and zip contain duplicate items
>>>>>> * Fix for issue #82 - Fix Windows tests by @shemnon
>>>>>> 
>>>>>> Misc:
>>>>>> * Adopt github actions to run CI
>>>>>> * Upgrade to Gradle 6.3
>>>>>> * Fix for issue #63 docker to build
>>>>>> 
>>>>>> Cheers,
>>>>>> 
>>>>>> Antoine
>>>>>> ---------------------------------------------------------------------
>>>>>> To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
>>>>>> For additional commands, e-mail: dev-help@tuweni.apache.org
>>>>>> 
>>>>>> 
>>>>> 
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
>>>>> For additional commands, e-mail: dev-help@tuweni.apache.org
>>>>> 
>>>>> 
>>> 
>>> 
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
>>> For additional commands, e-mail: dev-help@tuweni.apache.org
>>> 
>>> 
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
> For additional commands, e-mail: dev-help@tuweni.apache.org
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org


Re: [VOTE] Tuweni 1.1.0-incubating release

Posted by Antoine Toulme <an...@toulme.name>.
Here is my +1.

> On May 13, 2020, at 3:53 PM, Furkan KAMACI <fu...@gmail.com> wrote:
> 
> Hi Antoine,
> 
> I can file a bug for it (it may specific to my environment) and we can
> check it for the next release.
> 
> Kind Regards,
> Furkan KAMACI
> 
> On Thu, May 14, 2020 at 1:49 AM Antoine Toulme <an...@toulme.name> wrote:
> 
>> Should I make the build work with the src dist? File a bug and look at it
>> next release? What’s the requirement there, so I can know what to do?
>> 
>>> On May 13, 2020, at 3:41 PM, Furkan KAMACI <fu...@gmail.com>
>> wrote:
>>> 
>>> Hi,
>>> 
>>> +1 from me.
>>> 
>>> I checked:
>>> 
>>> - Incubating in name
>>> - DISCLAIMER exists
>>> - LICENSE and NOTICE are fine
>>> - No unexpected binary files
>>> - Checked PGP signatures
>>> - Checked Checksums
>>> - Code compiles and tests successfully run
>>> 
>>> PS: I couldn't build the project from src dist. I've downloaded it from
>>> GitHub tag.
>>> 
>>> Kind Regards,
>>> Furkan KAMACI
>>> 
>>> On Thu, May 14, 2020 at 12:29 AM Rob Dawson <ro...@apache.org> wrote:
>>> 
>>>> +1. Didn't get a chance to test it
>>>> 
>>>> On 2020/05/10 06:13:08, Antoine Toulme <an...@toulme.name> wrote:
>>>>> We're voting on the source distributions available here:
>>>>> 
>>>> 
>> https://dist.apache.org/repos/dist/dev/incubator/tuweni/1.1.0-incubating/
>>>>> The release tag is present here:
>>>>> 
>>>> 
>> https://github.com/apache/incubator-tuweni/releases/tag/v1.1.0-incubating
>>>>> 
>>>>> This release includes the following changes:
>>>>> 
>>>>> New:
>>>>> * Implement DNS discovery reader, reading from goerli and mainnet
>>>>> * Implement #71 - short hash string
>>>>> * Implement #72 - Upgrade codec dependency by @ajsutton
>>>>> * #74 and #75 enhance UInt256 performance by @shemnon
>>>>> 
>>>>> Changes:
>>>>> * Move to slf4j from logl
>>>>> * Simplify address and hash classes
>>>>> * Expose the ability to destroy public keys directly
>>>>> 
>>>>> Bug fixes:
>>>>> * Fix for issue #50 - FileBackedFingerprintRepository throws NPE if
>>>> fingerPrintFile has no parent Dir
>>>>> * Fix for issue #78 - Dist tar.gz and zip contain duplicate items
>>>>> * Fix for issue #82 - Fix Windows tests by @shemnon
>>>>> 
>>>>> Misc:
>>>>> * Adopt github actions to run CI
>>>>> * Upgrade to Gradle 6.3
>>>>> * Fix for issue #63 docker to build
>>>>> 
>>>>> Cheers,
>>>>> 
>>>>> Antoine
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
>>>>> For additional commands, e-mail: dev-help@tuweni.apache.org
>>>>> 
>>>>> 
>>>> 
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
>>>> For additional commands, e-mail: dev-help@tuweni.apache.org
>>>> 
>>>> 
>> 
>> 
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
>> For additional commands, e-mail: dev-help@tuweni.apache.org
>> 
>> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org


Re: [VOTE] Tuweni 1.1.0-incubating release

Posted by Furkan KAMACI <fu...@gmail.com>.
Hi Antoine,

I can file a bug for it (it may specific to my environment) and we can
check it for the next release.

Kind Regards,
Furkan KAMACI

On Thu, May 14, 2020 at 1:49 AM Antoine Toulme <an...@toulme.name> wrote:

> Should I make the build work with the src dist? File a bug and look at it
> next release? What’s the requirement there, so I can know what to do?
>
> > On May 13, 2020, at 3:41 PM, Furkan KAMACI <fu...@gmail.com>
> wrote:
> >
> > Hi,
> >
> > +1 from me.
> >
> > I checked:
> >
> > - Incubating in name
> > - DISCLAIMER exists
> > - LICENSE and NOTICE are fine
> > - No unexpected binary files
> > - Checked PGP signatures
> > - Checked Checksums
> > - Code compiles and tests successfully run
> >
> > PS: I couldn't build the project from src dist. I've downloaded it from
> > GitHub tag.
> >
> > Kind Regards,
> > Furkan KAMACI
> >
> > On Thu, May 14, 2020 at 12:29 AM Rob Dawson <ro...@apache.org> wrote:
> >
> >> +1. Didn't get a chance to test it
> >>
> >> On 2020/05/10 06:13:08, Antoine Toulme <an...@toulme.name> wrote:
> >>> We're voting on the source distributions available here:
> >>>
> >>
> https://dist.apache.org/repos/dist/dev/incubator/tuweni/1.1.0-incubating/
> >>> The release tag is present here:
> >>>
> >>
> https://github.com/apache/incubator-tuweni/releases/tag/v1.1.0-incubating
> >>>
> >>> This release includes the following changes:
> >>>
> >>> New:
> >>> * Implement DNS discovery reader, reading from goerli and mainnet
> >>> * Implement #71 - short hash string
> >>> * Implement #72 - Upgrade codec dependency by @ajsutton
> >>> * #74 and #75 enhance UInt256 performance by @shemnon
> >>>
> >>> Changes:
> >>> * Move to slf4j from logl
> >>> * Simplify address and hash classes
> >>> * Expose the ability to destroy public keys directly
> >>>
> >>> Bug fixes:
> >>> * Fix for issue #50 - FileBackedFingerprintRepository throws NPE if
> >> fingerPrintFile has no parent Dir
> >>> * Fix for issue #78 - Dist tar.gz and zip contain duplicate items
> >>> * Fix for issue #82 - Fix Windows tests by @shemnon
> >>>
> >>> Misc:
> >>> * Adopt github actions to run CI
> >>> * Upgrade to Gradle 6.3
> >>> * Fix for issue #63 docker to build
> >>>
> >>> Cheers,
> >>>
> >>> Antoine
> >>> ---------------------------------------------------------------------
> >>> To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
> >>> For additional commands, e-mail: dev-help@tuweni.apache.org
> >>>
> >>>
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
> >> For additional commands, e-mail: dev-help@tuweni.apache.org
> >>
> >>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
> For additional commands, e-mail: dev-help@tuweni.apache.org
>
>

Re: [VOTE] Tuweni 1.1.0-incubating release

Posted by Antoine Toulme <an...@toulme.name>.
Should I make the build work with the src dist? File a bug and look at it next release? What’s the requirement there, so I can know what to do?

> On May 13, 2020, at 3:41 PM, Furkan KAMACI <fu...@gmail.com> wrote:
> 
> Hi,
> 
> +1 from me.
> 
> I checked:
> 
> - Incubating in name
> - DISCLAIMER exists
> - LICENSE and NOTICE are fine
> - No unexpected binary files
> - Checked PGP signatures
> - Checked Checksums
> - Code compiles and tests successfully run
> 
> PS: I couldn't build the project from src dist. I've downloaded it from
> GitHub tag.
> 
> Kind Regards,
> Furkan KAMACI
> 
> On Thu, May 14, 2020 at 12:29 AM Rob Dawson <ro...@apache.org> wrote:
> 
>> +1. Didn't get a chance to test it
>> 
>> On 2020/05/10 06:13:08, Antoine Toulme <an...@toulme.name> wrote:
>>> We're voting on the source distributions available here:
>>> 
>> https://dist.apache.org/repos/dist/dev/incubator/tuweni/1.1.0-incubating/
>>> The release tag is present here:
>>> 
>> https://github.com/apache/incubator-tuweni/releases/tag/v1.1.0-incubating
>>> 
>>> This release includes the following changes:
>>> 
>>> New:
>>> * Implement DNS discovery reader, reading from goerli and mainnet
>>> * Implement #71 - short hash string
>>> * Implement #72 - Upgrade codec dependency by @ajsutton
>>> * #74 and #75 enhance UInt256 performance by @shemnon
>>> 
>>> Changes:
>>> * Move to slf4j from logl
>>> * Simplify address and hash classes
>>> * Expose the ability to destroy public keys directly
>>> 
>>> Bug fixes:
>>> * Fix for issue #50 - FileBackedFingerprintRepository throws NPE if
>> fingerPrintFile has no parent Dir
>>> * Fix for issue #78 - Dist tar.gz and zip contain duplicate items
>>> * Fix for issue #82 - Fix Windows tests by @shemnon
>>> 
>>> Misc:
>>> * Adopt github actions to run CI
>>> * Upgrade to Gradle 6.3
>>> * Fix for issue #63 docker to build
>>> 
>>> Cheers,
>>> 
>>> Antoine
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
>>> For additional commands, e-mail: dev-help@tuweni.apache.org
>>> 
>>> 
>> 
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
>> For additional commands, e-mail: dev-help@tuweni.apache.org
>> 
>> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org


Re: [VOTE] Tuweni 1.1.0-incubating release

Posted by Furkan KAMACI <fu...@gmail.com>.
Hi,

+1 from me.

I checked:

- Incubating in name
- DISCLAIMER exists
- LICENSE and NOTICE are fine
- No unexpected binary files
- Checked PGP signatures
- Checked Checksums
- Code compiles and tests successfully run

PS: I couldn't build the project from src dist. I've downloaded it from
GitHub tag.

Kind Regards,
Furkan KAMACI

On Thu, May 14, 2020 at 12:29 AM Rob Dawson <ro...@apache.org> wrote:

> +1. Didn't get a chance to test it
>
> On 2020/05/10 06:13:08, Antoine Toulme <an...@toulme.name> wrote:
> > We're voting on the source distributions available here:
> >
> https://dist.apache.org/repos/dist/dev/incubator/tuweni/1.1.0-incubating/
> > The release tag is present here:
> >
> https://github.com/apache/incubator-tuweni/releases/tag/v1.1.0-incubating
> >
> > This release includes the following changes:
> >
> > New:
> > * Implement DNS discovery reader, reading from goerli and mainnet
> > * Implement #71 - short hash string
> > * Implement #72 - Upgrade codec dependency by @ajsutton
> > * #74 and #75 enhance UInt256 performance by @shemnon
> >
> > Changes:
> > * Move to slf4j from logl
> > * Simplify address and hash classes
> > * Expose the ability to destroy public keys directly
> >
> > Bug fixes:
> > * Fix for issue #50 - FileBackedFingerprintRepository throws NPE if
> fingerPrintFile has no parent Dir
> > * Fix for issue #78 - Dist tar.gz and zip contain duplicate items
> > * Fix for issue #82 - Fix Windows tests by @shemnon
> >
> > Misc:
> > * Adopt github actions to run CI
> > * Upgrade to Gradle 6.3
> > * Fix for issue #63 docker to build
> >
> > Cheers,
> >
> > Antoine
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
> > For additional commands, e-mail: dev-help@tuweni.apache.org
> >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
> For additional commands, e-mail: dev-help@tuweni.apache.org
>
>

Re: [VOTE] Tuweni 1.1.0-incubating release

Posted by Rob Dawson <ro...@apache.org>.
+1. Didn't get a chance to test it

On 2020/05/10 06:13:08, Antoine Toulme <an...@toulme.name> wrote: 
> We're voting on the source distributions available here:
> https://dist.apache.org/repos/dist/dev/incubator/tuweni/1.1.0-incubating/
> The release tag is present here:
> https://github.com/apache/incubator-tuweni/releases/tag/v1.1.0-incubating
> 
> This release includes the following changes:
> 
> New:
> * Implement DNS discovery reader, reading from goerli and mainnet
> * Implement #71 - short hash string
> * Implement #72 - Upgrade codec dependency by @ajsutton 
> * #74 and #75 enhance UInt256 performance by @shemnon
> 
> Changes:
> * Move to slf4j from logl
> * Simplify address and hash classes
> * Expose the ability to destroy public keys directly
> 
> Bug fixes:
> * Fix for issue #50 - FileBackedFingerprintRepository throws NPE if fingerPrintFile has no parent Dir
> * Fix for issue #78 - Dist tar.gz and zip contain duplicate items
> * Fix for issue #82 - Fix Windows tests by @shemnon
> 
> Misc:
> * Adopt github actions to run CI
> * Upgrade to Gradle 6.3
> * Fix for issue #63 docker to build
> 
> Cheers,
> 
> Antoine
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
> For additional commands, e-mail: dev-help@tuweni.apache.org
> 
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org


Re: [VOTE] Tuweni 1.1.0-incubating release

Posted by Antoine Toulme <an...@toulme.name>.
Any feedback? For this release, I stripped out the tests from the source release. Last release, we saw duplicate files in the source release, and it was really big given that we have a lot of test resources.

> On May 9, 2020, at 11:13 PM, Antoine Toulme <an...@toulme.name> wrote:
> 
> We're voting on the source distributions available here:
> https://dist.apache.org/repos/dist/dev/incubator/tuweni/1.1.0-incubating/
> The release tag is present here:
> https://github.com/apache/incubator-tuweni/releases/tag/v1.1.0-incubating
> 
> This release includes the following changes:
> 
> New:
> * Implement DNS discovery reader, reading from goerli and mainnet
> * Implement #71 - short hash string
> * Implement #72 - Upgrade codec dependency by @ajsutton 
> * #74 and #75 enhance UInt256 performance by @shemnon
> 
> Changes:
> * Move to slf4j from logl
> * Simplify address and hash classes
> * Expose the ability to destroy public keys directly
> 
> Bug fixes:
> * Fix for issue #50 - FileBackedFingerprintRepository throws NPE if fingerPrintFile has no parent Dir
> * Fix for issue #78 - Dist tar.gz and zip contain duplicate items
> * Fix for issue #82 - Fix Windows tests by @shemnon
> 
> Misc:
> * Adopt github actions to run CI
> * Upgrade to Gradle 6.3
> * Fix for issue #63 docker to build
> 
> Cheers,
> 
> Antoine


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org