You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@poi.apache.org by bu...@apache.org on 2011/01/18 09:44:42 UTC
DO NOT REPLY [Bug 50607] New: Submitting patches for two new
function implementations(CLEAN and ADDRESS).
https://issues.apache.org/bugzilla/show_bug.cgi?id=50607
Summary: Submitting patches for two new function
implementations(CLEAN and ADDRESS).
Product: POI
Version: 3.8-dev
Platform: PC
Status: NEW
Severity: normal
Priority: P2
Component: POI Overall
AssignedTo: dev@poi.apache.org
ReportedBy: contact.aniket@gmail.com
Created an attachment (id=26503)
--> (https://issues.apache.org/bugzilla/attachment.cgi?id=26503)
Changes related to function implementation of CLEAN and ADDRESS.Newly added
files will be in Zip format.
Submitting patches for two new function implementations(CLEAN and ADDRESS).
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
DO NOT REPLY [Bug 50607] Submitting patches for two new function
implementations(CLEAN and ADDRESS).
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50607
Aniket <co...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
OS/Version| |Windows 7
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
DO NOT REPLY [Bug 50607] Submitting patches for two new function
implementations(CLEAN and ADDRESS).
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50607
--- Comment #4 from Aniket <co...@gmail.com> 2011-01-19 08:51:36 EST ---
(In reply to comment #3)
> *** Bug 50384 has been marked as a duplicate of this bug. ***
Thanks Yegor.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
DO NOT REPLY [Bug 50607] Submitting patches for two new function
implementations(CLEAN and ADDRESS).
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50607
Yegor Kozlov <ye...@dinom.ru> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
--- Comment #2 from Yegor Kozlov <ye...@dinom.ru> 2011-01-19 07:31:16 EST ---
Applied in r1060788 with some tweaks.
Your implementation of the CLEAN function was not quite correct. According to
the Excel docs, the CLEAN function removes the first 32 nonprinting characters
in the 7-bit ASCII code (values 0 through 31). All other characters are not
affected. This means that CLEAN does not remove any unicode characters above
ASCII, including nonprinting unicode characters (values 127, 129, 141, 143,
144, and 157). I changed your code to follow Excel's rules.
The ADDRESS function is actually a wrapper around
org.apache.poi.ss.util.CellReference. This is a fundamental class in POI and
should be cell reference operations.
Your implementation has a bug and throws IndexOutOfBoundsException for columns
greater than 702, i.e. Address.getColName(702) works and
Address.getColName(703) fails. I removed this method and used
CellReference#formatAsString instead.
Other than that, very good. Thanks for the good patch!
Regards,
Yegor
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
DO NOT REPLY [Bug 50607] Submitting patches for two new function
implementations(CLEAN and ADDRESS).
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50607
--- Comment #3 from Yegor Kozlov <ye...@dinom.ru> 2011-01-19 07:32:08 EST ---
*** Bug 50384 has been marked as a duplicate of this bug. ***
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
DO NOT REPLY [Bug 50607] Submitting patches for two new function
implementations(CLEAN and ADDRESS).
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50607
Aniket <co...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
OS/Version| |All
--- Comment #1 from Aniket <co...@gmail.com> 2011-01-19 00:35:55 EST ---
I have introduced two new excel function that were not implemented yet in POI.
The functions are CLEAN and ADDRESS. I have submitted a Zip file that contains
all the new files as well as the changed files. Kindly do the review so that I
can check-in the files.
Thanks,
Aniket
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org