You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pegasus.apache.org by "empiredan (via GitHub)" <gi...@apache.org> on 2023/12/22 12:32:05 UTC
[PR] fix: define DSN_MOCK_TEST only while building Pegasus for testing and fix meta server core dump due to null pointer to balancer [incubator-pegasus]
empiredan opened a new pull request, #1816:
URL: https://github.com/apache/incubator-pegasus/pull/1816
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
Re: [PR] fix: standby meta server exits abnormally with core dump after receiving the http request `/meta/cluster` [incubator-pegasus]
Posted by "empiredan (via GitHub)" <gi...@apache.org>.
empiredan merged PR #1816:
URL: https://github.com/apache/incubator-pegasus/pull/1816
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
Re: [PR] fix: standby meta server exits abnormally with core dump after receiving the http request `/meta/cluster` [incubator-pegasus]
Posted by "acelyc111 (via GitHub)" <gi...@apache.org>.
acelyc111 commented on code in PR #1816:
URL: https://github.com/apache/incubator-pegasus/pull/1816#discussion_r1435916035
##########
src/meta/meta_http_service.cpp:
##########
@@ -827,12 +828,26 @@ void meta_http_service::update_scenario_handler(const http_request &req, http_re
bool meta_http_service::redirect_if_not_primary(const http_request &req, http_response &resp)
{
-#ifdef DSN_MOCK_TEST
- return true;
+#ifdef MOCK_TEST
+ // Once MOCK_TEST is defined, the meta server must has been built with `./run.sh build --test`.
Review Comment:
It would be better to say `BUILD_TEST` or `MOCK_TEST` is enabled, because it's possible to build by cmake directly, not using ./run.sh build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org