You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "Shreyaskr1409 (via GitHub)" <gi...@apache.org> on 2025/03/08 10:45:20 UTC
[I] Implement `tree` explain for `ValuesExec` [datafusion]
Shreyaskr1409 opened a new issue, #15093:
URL: https://github.com/apache/datafusion/issues/15093
### Is your feature request related to a problem or challenge?
part of https://github.com/apache/datafusion/issues/14914
### Describe the solution you'd like
No response
### Describe alternatives you've considered
No response
### Additional context
I have also taken work for #15089 but I thought working on issues similar to the ones which were solved would be easier to start with.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Implement `tree` explain for `ValuesExec` [datafusion]
Posted by "Shreyaskr1409 (via GitHub)" <gi...@apache.org>.
Shreyaskr1409 commented on issue #15093:
URL: https://github.com/apache/datafusion/issues/15093#issuecomment-2708292831
@irenjj Yes, now I am working on the other JsonSink task after this. Actually I am new to this repository so I though it would have been easier to perform the simpler task as you already made some PRs which I did follow but this became the harder one to understand, but I just found this was deprecated.
Maybe we should remove ValuesExec part from #14914 as it is no longer needed. Anyways, thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Implement `tree` explain for `ValuesExec` [datafusion]
Posted by "Shreyaskr1409 (via GitHub)" <gi...@apache.org>.
Shreyaskr1409 closed issue #15093: Implement `tree` explain for `ValuesExec`
URL: https://github.com/apache/datafusion/issues/15093
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Implement `tree` explain for `ValuesExec` [datafusion]
Posted by "Shreyaskr1409 (via GitHub)" <gi...@apache.org>.
Shreyaskr1409 commented on issue #15093:
URL: https://github.com/apache/datafusion/issues/15093#issuecomment-2708197604
take
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Implement `tree` explain for `ValuesExec` [datafusion]
Posted by "Shreyaskr1409 (via GitHub)" <gi...@apache.org>.
Shreyaskr1409 commented on issue #15093:
URL: https://github.com/apache/datafusion/issues/15093#issuecomment-2708293268
please feel free to close this issue if there is no other input
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Implement `tree` explain for `ValuesExec` [datafusion]
Posted by "Shreyaskr1409 (via GitHub)" <gi...@apache.org>.
Shreyaskr1409 commented on issue #15093:
URL: https://github.com/apache/datafusion/issues/15093#issuecomment-2708280185
@irenjj , as per https://github.com/apache/datafusion/pull/14032 ValuesExec is deprecated. I tried running some simple queries which I thought would work like:
```sql
explain VALUES (1);
````
when I tried running it, I got the following results:
```
+ logical_plan Values: (Int64(1))
+ physical_plan
+ 01)┌───────────────────────────┐
+ 02)│ DataSourceExec │
+ 03)│ -------------------- │
+ 04)│ bytes: 128 │
+ 05)│ format: memory │
+ 06)│ rows: 1 │
+ 07)└───────────────────────────┘
```
Could this be because of the deprecation? Is there something which I could do to figure out why this isn't working out?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Implement `tree` explain for `ValuesExec` [datafusion]
Posted by "irenjj (via GitHub)" <gi...@apache.org>.
irenjj commented on issue #15093:
URL: https://github.com/apache/datafusion/issues/15093#issuecomment-2708287445
> #14032
Hi, @Shreyaskr1409 , maybe we don't need to implement the explain format since it's deprecated. cc @jonathanc-n .
I've noticed you've picked other tasks, maybe we can implement others first.❤️
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Implement `tree` explain for `ValuesExec` [datafusion]
Posted by "irenjj (via GitHub)" <gi...@apache.org>.
irenjj commented on issue #15093:
URL: https://github.com/apache/datafusion/issues/15093#issuecomment-2708295653
> [@irenjj](https://github.com/irenjj) Yes, now I am working on the other JsonSink task after this. Actually I am new to this repository so I though it would have been easier to perform the simpler task as you already made some PRs which I did follow but this became the harder one to understand as I just found this was deprecated.
>
> Maybe we should remove ValuesExec part from [#14914](https://github.com/apache/datafusion/issues/14914) as it is no longer needed. Anyways, thank you!
Thank you for your work! Feel free to reach out to me if you have any questions.❤️
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org