You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "tustvold (via GitHub)" <gi...@apache.org> on 2023/11/26 21:28:47 UTC
[I] Split up arrow_cast::cast [arrow-rs]
tustvold opened a new issue, #5125:
URL: https://github.com/apache/arrow-rs/issues/5125
**Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
<!--
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
(This section helps Arrow developers understand the context and *why* for this feature, in addition to the *what*)
-->
The cast kernel is currently implemented as a single large module. This has gotten fairly unwieldy, and should be split up.
**Describe the solution you'd like**
<!--
A clear and concise description of what you want to happen.
-->
I would like related functionality grouped together into crate private submodules, that are then composed into the top-level cast kernel
Ideas for modules might be:
* `arrow_cast::cast::decimal` - decimal handling logic
* `arrow_cast::cast::list` - list handling logic
* `arrow_cast::cast::dictionary` - dictionary handling logic
* `arrow_cast::cast::string` - string parsing and display logic
In order to make reviews more manageable, and minimize conflicts, these changes should be made across a number of smaller PRs
**Describe alternatives you've considered**
<!--
A clear and concise description of any alternative solutions or features you've considered.
-->
**Additional context**
<!--
Add any other context or screenshots about the feature request here.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Split up arrow_cast::cast [arrow-rs]
Posted by "monkwire (via GitHub)" <gi...@apache.org>.
monkwire commented on issue #5125:
URL: https://github.com/apache/arrow-rs/issues/5125#issuecomment-1999970131
@fansehep are you still working on this? I would like to submit some PRs for this if it is available.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Split up arrow_cast::cast [arrow-rs]
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold closed issue #5125: Split up arrow_cast::cast
URL: https://github.com/apache/arrow-rs/issues/5125
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Split up arrow_cast::cast [arrow-rs]
Posted by "fansehep (via GitHub)" <gi...@apache.org>.
fansehep commented on issue #5125:
URL: https://github.com/apache/arrow-rs/issues/5125#issuecomment-1827272985
Why smaller PullRequest?
I think just a pull request to split the `cast.rs` and move them to the new directory `cast`. Here we break the crate namespace.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Split up arrow_cast::cast [arrow-rs]
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on issue #5125:
URL: https://github.com/apache/arrow-rs/issues/5125#issuecomment-2002158452
There hasn't been any activity on this for almost 4 months, so I think it would be reasonable for you to pick this up if you're interested
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org