You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Hao Hao (Code Review)" <ge...@cloudera.org> on 2020/03/31 00:57:15 UTC
[kudu-CR] [ranger] authorize list tables should never throw NotAuthorized
Hao Hao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15609
Change subject: [ranger] authorize list tables should never throw NotAuthorized
......................................................................
[ranger] authorize list tables should never throw NotAuthorized
When authorizing list tables, the tables the user has no privileges
should be filtered out. However, that should not report an NotAuthorized
error even the user has no privileges over any tables. This also matches
the behavior with Sentry authorization.
Change-Id: I2d1df45a82acc70000783f0cbcce4d3c81840176
---
M src/kudu/ranger/ranger_client-test.cc
M src/kudu/ranger/ranger_client.cc
M src/kudu/ranger/ranger_client.h
3 files changed, 8 insertions(+), 17 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/09/15609/1
--
To view, visit http://gerrit.cloudera.org:8080/15609
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2d1df45a82acc70000783f0cbcce4d3c81840176
Gerrit-Change-Number: 15609
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
[kudu-CR] [ranger] authorize list tables should never throw NotAuthorized
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15609 )
Change subject: [ranger] authorize list tables should never throw NotAuthorized
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15609/1/src/kudu/ranger/ranger_client.cc
File src/kudu/ranger/ranger_client.cc:
http://gerrit.cloudera.org:8080/#/c/15609/1/src/kudu/ranger/ranger_client.cc@a394
PS1, Line 394:
:
:
:
:
:
> Now that we're revisiting this, it seems weird that the RangerClient is ret
Done
--
To view, visit http://gerrit.cloudera.org:8080/15609
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2d1df45a82acc70000783f0cbcce4d3c81840176
Gerrit-Change-Number: 15609
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 31 Mar 2020 06:21:03 +0000
Gerrit-HasComments: Yes
[kudu-CR] [ranger] authorize list tables should never throw NotAuthorized
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15609 )
Change subject: [ranger] authorize list tables should never throw NotAuthorized
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15609/2/src/kudu/ranger/ranger_client.cc
File src/kudu/ranger/ranger_client.cc:
http://gerrit.cloudera.org:8080/#/c/15609/2/src/kudu/ranger/ranger_client.cc@383
PS2, Line 383: Status s = subprocess_->Execute(req_list, &resp_list);
: if (s.ok()) {
> If we failed to execute, why not actually return an error? My point before
To be clear, I'm advocating for moving these empty list checks into the RangerAuthzProvider.
--
To view, visit http://gerrit.cloudera.org:8080/15609
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2d1df45a82acc70000783f0cbcce4d3c81840176
Gerrit-Change-Number: 15609
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 31 Mar 2020 06:48:46 +0000
Gerrit-HasComments: Yes
[kudu-CR] [ranger] authorize list tables should never throw NotAuthorized
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15609 )
Change subject: [ranger] authorize list tables should never throw NotAuthorized
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15609/1/src/kudu/ranger/ranger_client.cc
File src/kudu/ranger/ranger_client.cc:
http://gerrit.cloudera.org:8080/#/c/15609/1/src/kudu/ranger/ranger_client.cc@a394
PS1, Line 394:
:
:
:
:
:
> The change actually seems pretty small, but if you're uncomfortable making
Ack
--
To view, visit http://gerrit.cloudera.org:8080/15609
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2d1df45a82acc70000783f0cbcce4d3c81840176
Gerrit-Change-Number: 15609
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 31 Mar 2020 06:46:29 +0000
Gerrit-HasComments: Yes
[kudu-CR] [ranger] authorize list tables should never throw NotAuthorized
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15609 )
Change subject: [ranger] authorize list tables should never throw NotAuthorized
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15609/1/src/kudu/ranger/ranger_client.cc
File src/kudu/ranger/ranger_client.cc:
http://gerrit.cloudera.org:8080/#/c/15609/1/src/kudu/ranger/ranger_client.cc@a394
PS1, Line 394:
:
:
:
:
:
> Done
Can you do the same for the other methods while you're here? Otherwise the interfaces are inconsistent.
--
To view, visit http://gerrit.cloudera.org:8080/15609
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2d1df45a82acc70000783f0cbcce4d3c81840176
Gerrit-Change-Number: 15609
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 31 Mar 2020 06:23:26 +0000
Gerrit-HasComments: Yes
[kudu-CR] [ranger] authorize list tables should never throw NotAuthorized
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hello Attila Bukor, Kudu Jenkins, Andrew Wong, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15609
to look at the new patch set (#3).
Change subject: [ranger] authorize list tables should never throw NotAuthorized
......................................................................
[ranger] authorize list tables should never throw NotAuthorized
When authorizing list tables, the tables the user has no privileges
should be filtered out. However, that should not report an NotAuthorized
error even the user has no privileges over any tables. This also matches
the behavior with Sentry authorization.
Change-Id: I2d1df45a82acc70000783f0cbcce4d3c81840176
---
M src/kudu/master/ranger_authz_provider.cc
M src/kudu/ranger/ranger_client-test.cc
M src/kudu/ranger/ranger_client.cc
M src/kudu/ranger/ranger_client.h
4 files changed, 14 insertions(+), 21 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/09/15609/3
--
To view, visit http://gerrit.cloudera.org:8080/15609
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2d1df45a82acc70000783f0cbcce4d3c81840176
Gerrit-Change-Number: 15609
Gerrit-PatchSet: 3
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [ranger] authorize list tables should never throw NotAuthorized
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15609 )
Change subject: [ranger] authorize list tables should never throw NotAuthorized
......................................................................
[ranger] authorize list tables should never throw NotAuthorized
When authorizing list tables, the tables the user has no privileges
should be filtered out. However, that should not report an NotAuthorized
error even the user has no privileges over any tables. This also matches
the behavior with Sentry authorization.
Change-Id: I2d1df45a82acc70000783f0cbcce4d3c81840176
Reviewed-on: http://gerrit.cloudera.org:8080/15609
Tested-by: Kudu Jenkins
Reviewed-by: Andrew Wong <aw...@cloudera.com>
---
M src/kudu/master/ranger_authz_provider.cc
M src/kudu/ranger/ranger_client-test.cc
M src/kudu/ranger/ranger_client.cc
M src/kudu/ranger/ranger_client.h
4 files changed, 14 insertions(+), 21 deletions(-)
Approvals:
Kudu Jenkins: Verified
Andrew Wong: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/15609
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I2d1df45a82acc70000783f0cbcce4d3c81840176
Gerrit-Change-Number: 15609
Gerrit-PatchSet: 4
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [ranger] authorize list tables should never throw NotAuthorized
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15609 )
Change subject: [ranger] authorize list tables should never throw NotAuthorized
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15609/1/src/kudu/ranger/ranger_client.cc
File src/kudu/ranger/ranger_client.cc:
http://gerrit.cloudera.org:8080/#/c/15609/1/src/kudu/ranger/ranger_client.cc@a394
PS1, Line 394:
:
:
:
:
:
> Hmm, yeah, it would be nice to have a clean separation between RangerClient
The change actually seems pretty small, but if you're uncomfortable making the change, that's fine. We can address it later.
--
To view, visit http://gerrit.cloudera.org:8080/15609
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2d1df45a82acc70000783f0cbcce4d3c81840176
Gerrit-Change-Number: 15609
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 31 Mar 2020 06:42:13 +0000
Gerrit-HasComments: Yes
[kudu-CR] [ranger] authorize list tables should never throw NotAuthorized
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15609 )
Change subject: [ranger] authorize list tables should never throw NotAuthorized
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15609/2/src/kudu/ranger/ranger_client.cc
File src/kudu/ranger/ranger_client.cc:
http://gerrit.cloudera.org:8080/#/c/15609/2/src/kudu/ranger/ranger_client.cc@383
PS2, Line 383: Status s = subprocess_->Execute(req_list, &resp_list);
: if (s.ok()) {
If we failed to execute, why not actually return an error? My point before was that the RangerClient doesn't seem like the appropriate abstraction to be making authorization decisions, so returning NotAuthorized seems odd.
But if there's an actual failure trying to make a request in Ranger, that's still worth surfacing, no?
--
To view, visit http://gerrit.cloudera.org:8080/15609
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2d1df45a82acc70000783f0cbcce4d3c81840176
Gerrit-Change-Number: 15609
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 31 Mar 2020 06:47:02 +0000
Gerrit-HasComments: Yes
[kudu-CR] [ranger] authorize list tables should never throw NotAuthorized
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15609 )
Change subject: [ranger] authorize list tables should never throw NotAuthorized
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15609/2/src/kudu/ranger/ranger_client.cc
File src/kudu/ranger/ranger_client.cc:
http://gerrit.cloudera.org:8080/#/c/15609/2/src/kudu/ranger/ranger_client.cc@383
PS2, Line 383: unordered_set<string> allowed_tables;
: for (auto i =
> Sorry I wasn't clearer, by "empty list checks" I meant all the checks we ha
Ah, I see. Agree, I can do a follow up patch for it.
--
To view, visit http://gerrit.cloudera.org:8080/15609
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2d1df45a82acc70000783f0cbcce4d3c81840176
Gerrit-Change-Number: 15609
Gerrit-PatchSet: 3
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 01 Apr 2020 00:19:35 +0000
Gerrit-HasComments: Yes
[kudu-CR] [ranger] authorize list tables should never throw NotAuthorized
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15609 )
Change subject: [ranger] authorize list tables should never throw NotAuthorized
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15609/1/src/kudu/ranger/ranger_client.cc
File src/kudu/ranger/ranger_client.cc:
http://gerrit.cloudera.org:8080/#/c/15609/1/src/kudu/ranger/ranger_client.cc@a394
PS1, Line 394:
:
:
:
:
:
Now that we're revisiting this, it seems weird that the RangerClient is returning NotAuthorized errors at all. The interface would be a clearer IMO if the RangerAuthzProvider were the one making those decisions, and the RangerClient were only in charge of returning the list, empty or not. Could you extend this change to reflect that?
--
To view, visit http://gerrit.cloudera.org:8080/15609
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2d1df45a82acc70000783f0cbcce4d3c81840176
Gerrit-Change-Number: 15609
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 31 Mar 2020 01:09:35 +0000
Gerrit-HasComments: Yes
[kudu-CR] [ranger] authorize list tables should never throw NotAuthorized
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15609 )
Change subject: [ranger] authorize list tables should never throw NotAuthorized
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15609/2/src/kudu/ranger/ranger_client.cc
File src/kudu/ranger/ranger_client.cc:
http://gerrit.cloudera.org:8080/#/c/15609/2/src/kudu/ranger/ranger_client.cc@383
PS2, Line 383: unordered_set<string> allowed_tables;
: for (auto i =
> To be clear, I'm advocating for moving these empty list checks into the Ran
Done
--
To view, visit http://gerrit.cloudera.org:8080/15609
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2d1df45a82acc70000783f0cbcce4d3c81840176
Gerrit-Change-Number: 15609
Gerrit-PatchSet: 3
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 31 Mar 2020 19:16:20 +0000
Gerrit-HasComments: Yes
[kudu-CR] [ranger] authorize list tables should never throw NotAuthorized
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hello Attila Bukor, Kudu Jenkins, Andrew Wong, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15609
to look at the new patch set (#2).
Change subject: [ranger] authorize list tables should never throw NotAuthorized
......................................................................
[ranger] authorize list tables should never throw NotAuthorized
When authorizing list tables, the tables the user has no privileges
should be filtered out. However, that should not report an NotAuthorized
error even the user has no privileges over any tables. This also matches
the behavior with Sentry authorization.
Change-Id: I2d1df45a82acc70000783f0cbcce4d3c81840176
---
M src/kudu/master/ranger_authz_provider.cc
M src/kudu/ranger/ranger_client-test.cc
M src/kudu/ranger/ranger_client.cc
M src/kudu/ranger/ranger_client.h
4 files changed, 34 insertions(+), 40 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/09/15609/2
--
To view, visit http://gerrit.cloudera.org:8080/15609
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2d1df45a82acc70000783f0cbcce4d3c81840176
Gerrit-Change-Number: 15609
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [ranger] authorize list tables should never throw NotAuthorized
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15609 )
Change subject: [ranger] authorize list tables should never throw NotAuthorized
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15609/2/src/kudu/ranger/ranger_client.cc
File src/kudu/ranger/ranger_client.cc:
http://gerrit.cloudera.org:8080/#/c/15609/2/src/kudu/ranger/ranger_client.cc@383
PS2, Line 383: unordered_set<string> allowed_tables;
: for (auto i =
> Done
Sorry I wasn't clearer, by "empty list checks" I meant all the checks we have in the RangerClient. As is, the error handling code in RangerAuthzProvider is a bit confusing because it blurs where we're doing the error-checking, especially in creating authz tokens.
I'm fine punting on this for now though.
--
To view, visit http://gerrit.cloudera.org:8080/15609
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2d1df45a82acc70000783f0cbcce4d3c81840176
Gerrit-Change-Number: 15609
Gerrit-PatchSet: 3
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 31 Mar 2020 23:12:33 +0000
Gerrit-HasComments: Yes
[kudu-CR] [ranger] authorize list tables should never throw NotAuthorized
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15609 )
Change subject: [ranger] authorize list tables should never throw NotAuthorized
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15609/1/src/kudu/ranger/ranger_client.cc
File src/kudu/ranger/ranger_client.cc:
http://gerrit.cloudera.org:8080/#/c/15609/1/src/kudu/ranger/ranger_client.cc@a394
PS1, Line 394:
:
:
:
:
:
> Can you do the same for the other methods while you're here? Otherwise the
Hmm, yeah, it would be nice to have a clean separation between RangerClient and RangerAuthzProvider, I raised similar concern in previous patch and somehow it ended up with the current logic. However I would not prefer doing the same for other methods in this patch. Since the integration test is still not in place. I am afraid to massively update the current logic to introduce new bugs. I am manually testing the current patch. If you think consistency is important, I can revert the latest change, and we can do the improvement in a follow up patch.
--
To view, visit http://gerrit.cloudera.org:8080/15609
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2d1df45a82acc70000783f0cbcce4d3c81840176
Gerrit-Change-Number: 15609
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 31 Mar 2020 06:38:44 +0000
Gerrit-HasComments: Yes