[GitHub] [spark] steven-aerts commented on pull request #41712: [SPARK-44132][SQL] Materialize `Stream` of join column names to avoid codegen failure

["steven-aerts (via GitHub)" <gi...@apache.org>]

steven-aerts commented on PR #41712:
URL: https://github.com/apache/spark/pull/41712#issuecomment-1646664677

   @bersprockets 
   Hi Bruce,
   
   thanks for validating this for me.  I tried a few times but with my limited scala knowledge, I did not get anywhere.
   
   What do you think about fixing it in both places? 
   I can prepare on Monday a patch which fixes it in both places or on the `plan.output` place, or just rebase the current fix.
   
   Tell me which of the three solutions you like and I will act accordingly.
   I think that fixing it at both places is the best solution.  But I have no big opinion to go for one of the other two.
   
   Best regards,
   
   Steven


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org