You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues-all@impala.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2018/09/05 20:13:00 UTC
[jira] [Commented] (IMPALA-6923) Update/Cleanup
$IMPALA_HOME/tests/benchmark folder
[ https://issues.apache.org/jira/browse/IMPALA-6923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16604879#comment-16604879 ]
ASF subversion and git services commented on IMPALA-6923:
---------------------------------------------------------
Commit 37c66996a0819a81d8b209f73b52fd2c4c99129a in impala's branch refs/heads/master from njanarthanan
[ https://git-wip-us.apache.org/repos/asf?p=impala.git;h=37c6699 ]
IMPALA-6923: Remove create_database.py and perf_result_datastore.py
Description:
The current upstream usage indicates that report_benchmark_results.py script
is the only script in this folder that is used to generate a report comparing
performance between two given runs of the performance tests. The other two
scripts create_database.py and perf_result_datastore.py store some metrics
from a performance test run to database on a specified impala instance.
However they rely on some Internal resources not available to
external apache community to generate a meaningful interpretation/report of the
metrics stored in the performance database.
This change also removes lines of code from report_benchmark_results.py
that were previously parsing command line options, that were being used by the
two scripts that are being removed.
Change-Id: I2c9b04f0d0e8ca221e383aab2ba3ee53d968dd10
Reviewed-on: http://gerrit.cloudera.org:8080/11315
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
> Update/Cleanup $IMPALA_HOME/tests/benchmark folder
> ---------------------------------------------------
>
> Key: IMPALA-6923
> URL: https://issues.apache.org/jira/browse/IMPALA-6923
> Project: IMPALA
> Issue Type: Task
> Reporter: nithya
> Assignee: nithya
> Priority: Major
>
> Out of the 3 scripts in the benchmark folder (report_benchmark_results.py, create_database.py and perf_result_datastore.py), only report_benchmark_results.py is currently being used upstream to generate a report comparing performance benchmark numbers between two given runs of the performance tests. The other two scripts have some code that inserts some metrics from a given performance test run to a database on a specified impala instance. But these scripts depend on some internal resources to generate a meaningful interpretation of these metrics and these resources are not available to external apache community. Hence removing these scripts. While removing these scripts report_benchmark_results.py needs to be cleaned up to remove any code pointing to these scripts.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org