You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/04/17 16:56:28 UTC
[GitHub] [incubator-nuttx] anchao opened a new pull request, #6090: arm/a1x: fix compile break
anchao opened a new pull request, #6090:
URL: https://github.com/apache/incubator-nuttx/pull/6090
## Summary
arm/a1x: fix compile break
Signed-off-by: chao.an <an...@xiaomi.com>
## Impact
N/A
## Testing
ci check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #6090: arm/a1x: fix compile break
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on PR #6090:
URL: https://github.com/apache/incubator-nuttx/pull/6090#issuecomment-1100927558
Seems like we do not have proper configuration to check A1X on CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #6090: arm/a1x: fix compile break
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged PR #6090:
URL: https://github.com/apache/incubator-nuttx/pull/6090
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] anchao commented on a diff in pull request #6090: arm/a1x: fix compile break
Posted by GitBox <gi...@apache.org>.
anchao commented on code in PR #6090:
URL: https://github.com/apache/incubator-nuttx/pull/6090#discussion_r851790324
##########
arch/arm/src/a1x/a1x_pio.c:
##########
@@ -90,12 +90,11 @@ static inline int a1x_pio_pin(pio_pinset_t cfgset)
****************************************************************************/
#ifdef CONFIG_A1X_PIO_IRQ
-static int a1x_pio_interrupt(int irq, void *context)
+static int a1x_pio_interrupt(int irq, FAR void *context, FAR void *arg)
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6090: arm/a1x: fix compile break
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #6090:
URL: https://github.com/apache/incubator-nuttx/pull/6090#discussion_r851781228
##########
arch/arm/src/a1x/a1x_pio.c:
##########
@@ -90,12 +90,11 @@ static inline int a1x_pio_pin(pio_pinset_t cfgset)
****************************************************************************/
#ifdef CONFIG_A1X_PIO_IRQ
-static int a1x_pio_interrupt(int irq, void *context)
+static int a1x_pio_interrupt(int irq, FAR void *context, FAR void *arg)
Review Comment:
let's remove FAR, I have patch to remove FAR from all arch/arm.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org