You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/06/05 08:09:05 UTC

[GitHub] [spark] gengliangwang commented on pull request #28733: [SPARK-31705][SQL] Push more possible predicates through Join via CNF conversion

gengliangwang commented on pull request #28733:
URL: https://github.com/apache/spark/pull/28733#issuecomment-639327242


   As I talked to @wangyum offline, I am taking https://github.com/apache/spark/pull/28575 over for the CNF implementation and config naming. 
   
   There have been PRs for CNF conversion, such as https://github.com/apache/spark/pull/10444, https://github.com/apache/spark/pull/15558, #28575. The common issue is the recursive implementation can slow, or even cause a stack overflow exception.
   
   With this non-recursive implementation, the rule should be faster and more robust.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org