You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by theaccordance <gi...@git.apache.org> on 2015/07/15 22:05:53 UTC
[GitHub] cordova-lib pull request: Cb-8789
GitHub user theaccordance opened a pull request:
https://github.com/apache/cordova-lib/pull/261
Cb-8789
JIRA Issue: https://issues.apache.org/jira/browse/CB-8789
Updated ios_parser.js script to copy icon & launch image files to asset catalog location
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/theaccordance/cordova-lib CB-8789
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/261.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #261
----
commit 61420d8ed292efcd1118f0061ac08c78e7ff89b3
Author: Joe Mainwaring <jo...@highground.com>
Date: 2015-07-13T22:12:41Z
CB-8789 iOS Asset Catalog Support
- updated destination path for copying icons and launch images
commit c437a0b179d43482de738ea290ad05f8c4da0519
Author: Joe Mainwaring <jo...@highground.com>
Date: 2015-07-15T20:04:54Z
Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/cordova-lib into CB-8789
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib issue #261: Cb-8789
Posted by stevengill <gi...@git.apache.org>.
Github user stevengill commented on the issue:
https://github.com/apache/cordova-lib/pull/261
Looks like the issue has been resolved in cordova-ios. Marked for closing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: Cb-8789
Posted by theaccordance <gi...@git.apache.org>.
Github user theaccordance commented on the pull request:
https://github.com/apache/cordova-lib/pull/261#issuecomment-140809045
Apologies on the tests; I'll make sure to acquaint myself with the testing suite and update tests for further contributions.
Related note to this PR: There's a corresponding [PR in the cordova-lib project](https://github.com/apache/cordova-lib/pull/261) that also needs to be reviewed and accepted. That PR updates the process of copying icon/launch image assets into the xcode project to match the changes applied with this PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request #261: Cb-8789
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/261
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org