You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by GitBox <gi...@apache.org> on 2022/07/23 06:57:47 UTC
[GitHub] [zeppelin] HYEEWON opened a new pull request, #4424: [ZEPPELIN-5779] Remove pig interpreter
HYEEWON opened a new pull request, #4424:
URL: https://github.com/apache/zeppelin/pull/4424
### What is this PR for?
* Remove pig interpreter
### What type of PR is it?
Refactoring
### Todos
* Remove pig and related things
### What is the Jira issue?
[ZEPPELIN-5779](https://issues.apache.org/jira/browse/ZEPPELIN-5779)
### How should this be tested?
* CI
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need to update? Yes, Edited
* Is there breaking changes for older versions? No
* Does this needs documentation? Yes, Edited
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] HYEEWON commented on a diff in pull request #4424: [ZEPPELIN-5779] Remove pig interpreter
Posted by GitBox <gi...@apache.org>.
HYEEWON commented on code in PR #4424:
URL: https://github.com/apache/zeppelin/pull/4424#discussion_r928582951
##########
zeppelin-web/karma.conf.js:
##########
@@ -67,6 +67,7 @@ module.exports = function(config) {
'bower_components/ace-builds/src-noconflict/keybinding-emacs.js',
'bower_components/ace-builds/src-noconflict/ext-language_tools.js',
'bower_components/ace-builds/src-noconflict/theme-chrome.js',
+ 'bower_components/ace-builds/src-noconflict/mode-javascript.js',
Review Comment:
I tested on Windows and Linux, the result was same.
1. Clone apache/zeppelin
2. Build with command 'mvn clean package -DskipTests -Phadoop2 -X'
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] jongyoul merged pull request #4424: [ZEPPELIN-5779] Remove pig interpreter
Posted by GitBox <gi...@apache.org>.
jongyoul merged PR #4424:
URL: https://github.com/apache/zeppelin/pull/4424
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] jongyoul commented on a diff in pull request #4424: [ZEPPELIN-5779] Remove pig interpreter
Posted by GitBox <gi...@apache.org>.
jongyoul commented on code in PR #4424:
URL: https://github.com/apache/zeppelin/pull/4424#discussion_r928223437
##########
zeppelin-web/karma.conf.js:
##########
@@ -67,6 +67,7 @@ module.exports = function(config) {
'bower_components/ace-builds/src-noconflict/keybinding-emacs.js',
'bower_components/ace-builds/src-noconflict/ext-language_tools.js',
'bower_components/ace-builds/src-noconflict/theme-chrome.js',
+ 'bower_components/ace-builds/src-noconflict/mode-javascript.js',
Review Comment:
Is this related to this PR? Otherwise, could you please explain what it is?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] HYEEWON commented on a diff in pull request #4424: [ZEPPELIN-5779] Remove pig interpreter
Posted by GitBox <gi...@apache.org>.
HYEEWON commented on code in PR #4424:
URL: https://github.com/apache/zeppelin/pull/4424#discussion_r928261412
##########
zeppelin-web/karma.conf.js:
##########
@@ -67,6 +67,7 @@ module.exports = function(config) {
'bower_components/ace-builds/src-noconflict/keybinding-emacs.js',
'bower_components/ace-builds/src-noconflict/ext-language_tools.js',
'bower_components/ace-builds/src-noconflict/theme-chrome.js',
+ 'bower_components/ace-builds/src-noconflict/mode-javascript.js',
Review Comment:
It is not related with removing pig. It was automatically added when building Zeppelin, so I just included in the pr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] jongyoul commented on a diff in pull request #4424: [ZEPPELIN-5779] Remove pig interpreter
Posted by GitBox <gi...@apache.org>.
jongyoul commented on code in PR #4424:
URL: https://github.com/apache/zeppelin/pull/4424#discussion_r928268271
##########
zeppelin-web/karma.conf.js:
##########
@@ -67,6 +67,7 @@ module.exports = function(config) {
'bower_components/ace-builds/src-noconflict/keybinding-emacs.js',
'bower_components/ace-builds/src-noconflict/ext-language_tools.js',
'bower_components/ace-builds/src-noconflict/theme-chrome.js',
+ 'bower_components/ace-builds/src-noconflict/mode-javascript.js',
Review Comment:
It doesn't seem to make any issue but it's a bit weird that it was added while building it. Could you please check it again? If it does, please let me know how to reproduce it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org