[jira] [Commented] (DRILL-584) ExpressionTreeMaterializer injects incorrect implicit casts

["Aman Sinha (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DRILL-584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14233856#comment-14233856 ] 

Aman Sinha commented on DRILL-584:
----------------------------------

+1 .  looks good.  I did verify that CastVarBinaryToDate already exists, so your exact resolver will make use of that for the TPCH queries. 

> ExpressionTreeMaterializer injects incorrect implicit casts
> -----------------------------------------------------------
>
>                 Key: DRILL-584
>                 URL: https://issues.apache.org/jira/browse/DRILL-584
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Execution - Codegen
>            Reporter: Mehant Baid
>            Assignee: Mehant Baid
>             Fix For: 0.8.0
>
>         Attachments: DRILL-584.patch
>
>
> In ExpressionTreeMaterializer.visitFunctionCall() we try to get a best match between the DrillFuncHolder and the input call. We may match the input call with a DrillFuncHolder whose argument type is different from that of the input, but is allowed to be implicitly cast as per the precedence rules. 
> However when we inject implicit casts to compensate for the difference in argument types, we again use the same matching method to resolve the implicit cast to DrillFuncHolder. In the case of implicit casts should not match with a DrillFuncHolder that has different argument types than the input. We should return only the DrillFuncHolder that exactly matches the argument types and if no such holder is present should return NULL.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)