You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/07/17 15:46:05 UTC
[GitHub] [arrow-datafusion] andygrove opened a new pull request #738: Ballista: Prep for fixing shuffle mechansim, part 1
andygrove opened a new pull request #738:
URL: https://github.com/apache/arrow-datafusion/pull/738
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #737.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
This fixes a bug introduced in #712 and also gets us closer to truly supporting shuffle.
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
- Executors now collect meta-data from ShuffleWriterExec about the output partitions and return this information to the scheduler (where it is currently ignored)
- Comments are added where the current design is broken, with links to the relevant GitHub issue
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
No
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] andygrove commented on pull request #738: Ballista: Prep for fixing shuffle mechansim, part 1
Posted by GitBox <gi...@apache.org>.
andygrove commented on pull request #738:
URL: https://github.com/apache/arrow-datafusion/pull/738#issuecomment-883410584
@alamb No problem at all. Ballista is still very early and experimental (although now it is actually close to usable) so I think it has been hard for others to start contributing. My plan now is to focus on performance and scalability testing and optimizations and generally tidy things up and add documentation to make it easier for others to get involved. I think once we can demonstrate the value of Ballista then it will start to get some adoption and this will drive contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] andygrove merged pull request #738: Ballista: Prep for fixing shuffle mechansim, part 1
Posted by GitBox <gi...@apache.org>.
andygrove merged pull request #738:
URL: https://github.com/apache/arrow-datafusion/pull/738
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] andygrove merged pull request #738: Ballista: Prep for fixing shuffle mechansim, part 1
Posted by GitBox <gi...@apache.org>.
andygrove merged pull request #738:
URL: https://github.com/apache/arrow-datafusion/pull/738
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] andygrove commented on pull request #738: Ballista: Prep for fixing shuffle mechansim, part 1
Posted by GitBox <gi...@apache.org>.
andygrove commented on pull request #738:
URL: https://github.com/apache/arrow-datafusion/pull/738#issuecomment-882638494
If there are no objections I will go ahead and merge this tonight since it only touches Ballista files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] andygrove merged pull request #738: Ballista: Prep for fixing shuffle mechansim, part 1
Posted by GitBox <gi...@apache.org>.
andygrove merged pull request #738:
URL: https://github.com/apache/arrow-datafusion/pull/738
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #738: Ballista: Prep for fixing shuffle mechansim, part 1
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #738:
URL: https://github.com/apache/arrow-datafusion/pull/738#issuecomment-883336689
Looks good @andygrove -- I am sorry I have been focusing on arrow and DataFusion and don't have much experience with Ballista -- are there others in the Ballista community we can ask for feedback in the future?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] andygrove commented on pull request #738: Ballista: Prep for fixing shuffle mechansim, part 1
Posted by GitBox <gi...@apache.org>.
andygrove commented on pull request #738:
URL: https://github.com/apache/arrow-datafusion/pull/738#issuecomment-882638494
If there are no objections I will go ahead and merge this tonight since it only touches Ballista files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] andygrove commented on pull request #738: Ballista: Prep for fixing shuffle mechansim, part 1
Posted by GitBox <gi...@apache.org>.
andygrove commented on pull request #738:
URL: https://github.com/apache/arrow-datafusion/pull/738#issuecomment-882638494
If there are no objections I will go ahead and merge this tonight since it only touches Ballista files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb edited a comment on pull request #738: Ballista: Prep for fixing shuffle mechansim, part 1
Posted by GitBox <gi...@apache.org>.
alamb edited a comment on pull request #738:
URL: https://github.com/apache/arrow-datafusion/pull/738#issuecomment-883336689
Looks good @andygrove -- I am sorry I have been focusing on arrow and DataFusion and don't have much experience with Ballista -- are there others in the Ballista community we can ask for feedback in the future so these PRs don't hang out for too long?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org