You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "junrao (via GitHub)" <gi...@apache.org> on 2023/04/03 22:12:08 UTC

[GitHub] [kafka] junrao commented on a diff in pull request #13454: MINOR: move RecordReader from org.apache.kafka.tools to org.apache.co…

junrao commented on code in PR #13454:
URL: https://github.com/apache/kafka/pull/13454#discussion_r1156500801


##########
clients/src/main/java/org/apache/kafka/common/RecordReader.java:
##########
@@ -14,10 +14,9 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-package org.apache.kafka.tools;
+package org.apache.kafka.common;

Review Comment:
   Another possibility is to move this to the tools module under the package org.apache.kafka.tools.api, which seems a bit cleaner?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org