[GitHub] [incubator-gobblin] arekusuri edited a comment on issue #2910: Add typed config in salesforce

[GitBox <gi...@apache.org>]

arekusuri edited a comment on issue #2910: Add typed config in salesforce
URL: https://github.com/apache/incubator-gobblin/pull/2910#issuecomment-595499648
 
 
   > Alex. Thanks for taking the action to improve the config key story. Is there a grand plan for the gobblin configuration system? Or you're just trying to improve life of gobblin dev to work with salesforce configurations, for gobblin users, they have to deal with strings.
   
   It is flexible enough for both cases, because it takes a property dataset to fill into a config class instance. There is no Gobblin framework structure change.
   If Gobblin core doesn't work to adopt it yet, gobblin core can continue use the old way.
   Runtime feature are all completed, includes "string". The type is decided by config field's type.
   >   @Key("salesforce.test.jobIdAndBulkIdPair")@Default("1:11")@StringRegex("[0-9]+:[0-9]+")
     public String jobIdAndBulkIdPair;
   
   In this code, `jobIdAndBulkIdPair` will be filled in with string value. And the value set up in INI file must satisfy the restrain `regex [0-9]+:[0-9]+`
   Future plan is to valid whether INI value satisfy the regex at compiling time by implement an annotation processor.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services