You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/11/25 08:14:52 UTC
[GitHub] [airflow] jyotsa09 opened a new issue, #27907: Password in not masked in audit logs for connections/variables
jyotsa09 opened a new issue, #27907:
URL: https://github.com/apache/airflow/issues/27907
### Apache Airflow version
main (development)
### What happened
Password for connections and variables with secret in the name are not masked in audit logs.
<img width="1337" alt="Screenshot 2022-11-25 at 12 58 59 PM" src="https://user-images.githubusercontent.com/88504849/203932123-c47fd66f-8e63-4bc6-9bf1-b9395cb26675.png">
<img width="1352" alt="Screenshot 2022-11-25 at 12 56 32 PM" src="https://user-images.githubusercontent.com/88504849/203932220-3f02984c-94b5-4773-8767-6f19cb0ceff0.png">
<img width="1328" alt="Screenshot 2022-11-25 at 1 43 40 PM" src="https://user-images.githubusercontent.com/88504849/203933183-e97b2358-9414-45c8-ab8f-d2f913117301.png">
### What you think should happen instead
Password/value should be masked
### How to reproduce
1. Create a connection or variable(with secret in the name i.e. test_secret)
2. Open audit logs
3. Observe the password
### Operating System
mac os
### Versions of Apache Airflow Providers
_No response_
### Deployment
Virtualenv installation
### Deployment details
_No response_
### Anything else
_No response_
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://github.com/apache/airflow/blob/main/CODE_OF_CONDUCT.md)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
RE: [GitHub] [airflow] jyotsa09 opened a new issue, #27907: Password in not masked in audit logs for connections/variables
Posted by Madilynn Flynn <ma...@clinkz.live>.
Hi,
Just checking, are you interested acquiring the list of attendees? Please respond my email. I'm waiting for your response.
We are discussing about Prices And, provide the discount cost.
Thank you,
-----Original Message-----
From: GitBox <gi...@apache.org>
Sent: Friday, November 25, 2022 12:15 AM
To: commits@airflow.apache.org
Subject: [GitHub] [airflow] jyotsa09 opened a new issue, #27907: Password in not masked in audit logs for connections/variables
jyotsa09 opened a new issue, #27907:
URL: https://github.com/apache/airflow/issues/27907
### Apache Airflow version
main (development)
### What happened
Password for connections and variables with secret in the name are not masked in audit logs.
<img width="1337" alt="Screenshot 2022-11-25 at 12 58 59 PM" src="https://user-images.githubusercontent.com/88504849/203932123-c47fd66f-8e63-4bc6-9bf1-b9395cb26675.png">
<img width="1352" alt="Screenshot 2022-11-25 at 12 56 32 PM" src="https://user-images.githubusercontent.com/88504849/203932220-3f02984c-94b5-4773-8767-6f19cb0ceff0.png">
<img width="1328" alt="Screenshot 2022-11-25 at 1 43 40 PM" src="https://user-images.githubusercontent.com/88504849/203933183-e97b2358-9414-45c8-ab8f-d2f913117301.png">
### What you think should happen instead
Password/value should be masked
### How to reproduce
1. Create a connection or variable(with secret in the name i.e. test_secret)
2. Open audit logs
3. Observe the password
### Operating System
mac os
### Versions of Apache Airflow Providers
_No response_
### Deployment
Virtualenv installation
### Deployment details
_No response_
### Anything else
_No response_
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://github.com/apache/airflow/blob/main/CODE_OF_CONDUCT.md)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ephraimbuddy closed issue #27907: Password is not masked in audit logs for connections/variables
Posted by GitBox <gi...@apache.org>.
ephraimbuddy closed issue #27907: Password is not masked in audit logs for connections/variables
URL: https://github.com/apache/airflow/issues/27907
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ephraimbuddy commented on issue #27907: Password is not masked in audit logs for connections/variables
Posted by GitBox <gi...@apache.org>.
ephraimbuddy commented on issue #27907:
URL: https://github.com/apache/airflow/issues/27907#issuecomment-1327839476
This looks like the fix:
```diff
diff --git a/airflow/www/decorators.py b/airflow/www/decorators.py
index 079c91fdfa..16a886098b 100644
--- a/airflow/www/decorators.py
+++ b/airflow/www/decorators.py
@@ -30,6 +30,7 @@ from pendulum.parsing.exceptions import ParserError
from airflow.models import Log
from airflow.utils.session import create_session
+from airflow.utils.log import secrets_masker
T = TypeVar("T", bound=Callable)
@@ -56,6 +57,7 @@ def action_logging(func: Callable | None = None, event: str | None = None) -> Ca
for k, v in chain(request.values.items(multi=True), request.view_args.items())
if k not in fields_skip_logging
]
+ extra_fields = [(k, '****') if secrets_masker.should_hide_value_for_key(k) else (k, v) for k, v in extra_fields]
params = {k: v for k, v in chain(request.values.items(), request.view_args.items())}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org