[jira] Commented: (MYFACES-1031) test cases didnt reset the facesContext to null

["Simon Kitching (JIRA)" <de...@myfaces.apache.org>]

    [ http://issues.apache.org/jira/browse/MYFACES-1031?page=comments#action_12362823 ] 

Simon Kitching commented on MYFACES-1031:
-----------------------------------------

Mario, the AbstractTestCase class is currently under javax.faces.component.

What do you think of putting it under org.apache.myfaces, like FacesContextHelper? They seem to belong together, and I guess this 
base class is useful for tests other than those under javax.faces.component....

> test cases didnt reset the facesContext to null
> -----------------------------------------------
>
>          Key: MYFACES-1031
>          URL: http://issues.apache.org/jira/browse/MYFACES-1031
>      Project: MyFaces
>         Type: Bug
>   Components: General
>     Versions: Nightly
>     Reporter: Mario Ivankovits
>     Assignee: Simon Kitching
>  Attachments: AbstractTestCase.java, FacesContextHelper.java, test_ctx_null.diff
>
> If a test-case sets a facesContext and forgets to remove it again subsequent tests may fail if they use "null" as wanted facesContext.
> The patch introduce a new AbstractTestCase which
> *) ensure the facesContext is null in startUp()
> *) set the facesContext to null in tearDown()
> I changed UISelectManyTest and UIComponentBaseTest to use this new super class

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira