[jira] [Commented] (DERBY-5968) A failed connection attempt may nevertheless manage to boot the database.

["Knut Anders Hatlen (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DERBY-5968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13491599#comment-13491599 ] 

Knut Anders Hatlen commented on DERBY-5968:
-------------------------------------------

Since the startSlave command doesn't return until the slave is connected to the master, I don't think we have any way with the current API to tell that the slave is up and ready to accept connections from the master. We could of course make the test sleep a little while before attempting to start the master, but that doesn't sound very robust.

I think all the replication tests use this approach when they start the master. See for example the ReplicationRun.startMaster_direct() method. However, most of the other replication tests run the master in a separate process so that the timing could be different, which might explain why you only see this in one test.
                
> A failed connection attempt may nevertheless manage to boot the database.
> -------------------------------------------------------------------------
>
>                 Key: DERBY-5968
>                 URL: https://issues.apache.org/jira/browse/DERBY-5968
>             Project: Derby
>          Issue Type: Bug
>          Components: Services
>    Affects Versions: 10.10.0.0
>            Reporter: Rick Hillegas
>         Attachments: derby-5968-01-aa-shutdownDatabaseIfBootingConnectionFails.diff, derby-5968-01-ab-shutdownDatabaseIfBootingConnectionFails.diff, derby-5968-01-ac-shutdownDatabaseIfBootingConnectionFails.diff
>
>
> A connection attempt may fail but still manage to boot the database. If possible, we should try to bring down the database after the connection failure.
> 1) Here is an example of this problem: If you use bad credentials to connect to a database, you will fail to get a connection. That's correct behavior. However, Derby must boot the database in order to discover its authentication mechanism. The database remains booted after this check.
> 2) There are other examples of this problem. For instance, if a user with good credentials tries to change the boot password on an encrypted database, then the connection attempt will fail, but the database will remain booted. This can cause silent failures on later attempts to re-encrypt or un-encrypt a database after the low-privilege or nonexistent user manages to boot the database. The connection attempt will succeed, leading the DBO to think that the re-encryption worked. But actually re-encryption did not take place because the database was already booted.
> I regard this silent failure as a security vulnerability.
> The following script shows problem (1):
> connect 'jdbc:derby:db;create=true;user=test_dbo';
> call syscs_util.syscs_create_user( 'test_dbo', 'test_dbopassword' );
> -- shutdown the database
> connect 'jdbc:derby:db;shutdown=true';
> -- need credentials in order to get a connection
> connect 'jdbc:derby:db';
> connect 'jdbc:derby:db;user=test_dbo;password=test_dbopassword';
> select count(*) from sys.systables;
> -- shutdown the database
> connect 'jdbc:derby:db;shutdown=true;user=test_dbo;password=test_dbopassword';
> -- try to shutdown the database again. since it is already shutdown, you will get a message saying it can't be found.
> connect 'jdbc:derby:db;shutdown=true;user=test_dbo;password=test_dbopassword';
> -- now try to boot with bad credentials. you don't get a connection but the database boots.
> connect 'jdbc:derby:db;user=alice;password=alicepassword;bootPassword=foobarwibblewombat';
> select count(*) from sys.systables;
> -- the shutdown command succeeds because alice managed to boot the database
> -- even though she isn't a legal user.
> connect 'jdbc:derby:db;shutdown=true;user=test_dbo;password=test_dbopassword';

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira