[GitHub] [royale-asjs] estanglerbm commented on issue #996: Error on indexed array syntax with string literal on Proxy

[GitBox <gi...@apache.org>]

estanglerbm commented on issue #996:
URL: https://github.com/apache/royale-asjs/issues/996#issuecomment-753470836


   @carlosrovira I haven't tried that option in debug mode (I use it regularly in release mode).
   
   But I don't think the compiler should be doing this in any mode by default.  This issue lists several cases where the compiler generates invalid code (involving single quotes), in addition to several cases of wrong behavior (involving double quotes).
   
   The ObjectProxy code I submitted has a workaround for the double quotes issue, so while all the situations need a fix, the single quotes problem is the more severe, at the moment.
   
   **I think the core problem is that the compiler is adding single quotes as part of ``getProperty('...')`` without check if the value is already surrounded by single quotes or double quotes.**  If it's already surrounded by single or double quotes, it should just add it as ``getProperty(...)``.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org