You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@qpid.apache.org by ro...@apache.org on 2014/09/26 11:34:12 UTC

[1/2] git commit: add a note

Repository: qpid-jms
Updated Branches:
  refs/heads/master 44d6e320c -> 63ab8c1bc


add a note


Project: http://git-wip-us.apache.org/repos/asf/qpid-jms/repo
Commit: http://git-wip-us.apache.org/repos/asf/qpid-jms/commit/6abc69bb
Tree: http://git-wip-us.apache.org/repos/asf/qpid-jms/tree/6abc69bb
Diff: http://git-wip-us.apache.org/repos/asf/qpid-jms/diff/6abc69bb

Branch: refs/heads/master
Commit: 6abc69bbf17f734074b99ddde1a4dd1b59f3c54c
Parents: 44d6e32
Author: Robert Gemmell <ro...@apache.org>
Authored: Fri Sep 26 10:09:10 2014 +0100
Committer: Robert Gemmell <ro...@apache.org>
Committed: Fri Sep 26 10:09:10 2014 +0100

----------------------------------------------------------------------
 .../qpid/jms/provider/amqp/message/AmqpDestinationHelper.java      | 2 ++
 1 file changed, 2 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/qpid-jms/blob/6abc69bb/qpid-jms-client/src/main/java/org/apache/qpid/jms/provider/amqp/message/AmqpDestinationHelper.java
----------------------------------------------------------------------
diff --git a/qpid-jms-client/src/main/java/org/apache/qpid/jms/provider/amqp/message/AmqpDestinationHelper.java b/qpid-jms-client/src/main/java/org/apache/qpid/jms/provider/amqp/message/AmqpDestinationHelper.java
index 2402143..a7ac472 100644
--- a/qpid-jms-client/src/main/java/org/apache/qpid/jms/provider/amqp/message/AmqpDestinationHelper.java
+++ b/qpid-jms-client/src/main/java/org/apache/qpid/jms/provider/amqp/message/AmqpDestinationHelper.java
@@ -135,6 +135,7 @@ public class AmqpDestinationHelper {
     }
 
     public void setToAddressFromDestination(AmqpJmsMessageFacade message, JmsDestination destination) {
+        //TODO: don't we need to clear any existing value and type annotation?
         if (destination == null) {
             return;
         }
@@ -152,6 +153,7 @@ public class AmqpDestinationHelper {
     }
 
     public void setReplyToAddressFromDestination(AmqpJmsMessageFacade message, JmsDestination destination) {
+        //TODO: don't we need to clear any existing value and type annotation?
         if (destination == null) {
             return;
         }


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org
For additional commands, e-mail: commits-help@qpid.apache.org


[2/2] git commit: fix exception message to state correct range

Posted by ro...@apache.org.
fix exception message to state correct range


Project: http://git-wip-us.apache.org/repos/asf/qpid-jms/repo
Commit: http://git-wip-us.apache.org/repos/asf/qpid-jms/commit/63ab8c1b
Tree: http://git-wip-us.apache.org/repos/asf/qpid-jms/tree/63ab8c1b
Diff: http://git-wip-us.apache.org/repos/asf/qpid-jms/diff/63ab8c1b

Branch: refs/heads/master
Commit: 63ab8c1bc085ba850158fe059595c0366f512fcb
Parents: 6abc69b
Author: Robert Gemmell <ro...@apache.org>
Authored: Fri Sep 26 10:27:45 2014 +0100
Committer: Robert Gemmell <ro...@apache.org>
Committed: Fri Sep 26 10:27:45 2014 +0100

----------------------------------------------------------------------
 .../qpid/jms/provider/amqp/message/AmqpJmsMessageFacade.java       | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/qpid-jms/blob/63ab8c1b/qpid-jms-client/src/main/java/org/apache/qpid/jms/provider/amqp/message/AmqpJmsMessageFacade.java
----------------------------------------------------------------------
diff --git a/qpid-jms-client/src/main/java/org/apache/qpid/jms/provider/amqp/message/AmqpJmsMessageFacade.java b/qpid-jms-client/src/main/java/org/apache/qpid/jms/provider/amqp/message/AmqpJmsMessageFacade.java
index c0d4d9f..aa34d24 100644
--- a/qpid-jms-client/src/main/java/org/apache/qpid/jms/provider/amqp/message/AmqpJmsMessageFacade.java
+++ b/qpid-jms-client/src/main/java/org/apache/qpid/jms/provider/amqp/message/AmqpJmsMessageFacade.java
@@ -557,7 +557,7 @@ public class AmqpJmsMessageFacade implements JmsMessageFacade {
         if (ttl != null && ttl >= 0 && ttl <= MAX_UINT) {
             userSpecifiedTTL = ttl;
         } else {
-            throw new MessageFormatException(JMS_AMQP_TTL + " must be a long with value in range 0 to 2^31 - 1");
+            throw new MessageFormatException(JMS_AMQP_TTL + " must be a long with value in range 0 to 2^32 - 1");
         }
     }
 


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org
For additional commands, e-mail: commits-help@qpid.apache.org