You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Gaurav Aradhye <ga...@clogeny.com> on 2015/02/19 11:00:38 UTC
Review Request 31181: CLOUDSTACK-8268: Code improvement -
test_stopped_vm.py
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31181/
-----------------------------------------------------------
Review request for cloudstack and SrikanteswaraRao Talluri.
Bugs: CLOUDSTACK-8268
https://issues.apache.org/jira/browse/CLOUDSTACK-8268
Repository: cloudstack-git
Description
-------
1. Read all the test data from test_data.py
2. Remove hard coded test data (Services class) from the test suite
3. Fix autopep8 issues
4. Move bootableVolume to configurableData section and make relevant changes in test case to read the data according to hypervisor
Diffs
-----
test/integration/component/test_stopped_vm.py 1cefc07
tools/marvin/marvin/config/test_data.py e8365ed
Diff: https://reviews.apache.org/r/31181/diff/
Testing
-------
Test Deploy HA enabled Virtual Machine with startvm=false ... === TestName: test_01_deploy_ha_vm_startvm_false | Status : SUCCESS ===
ok
Test Deploy HA enabled Virtual Machine from ISO ... SKIP: Bootable Iso URL not present in test data for xenserver
Test Deploy HA enabled Virtual Machine from ISO with startvm=false ... === TestName: test_03_deploy_ha_vm_iso_startvm_false | Status :
SUCCESS ===
ok
Test deploy VM on specific host ... === TestName: test_deployVmOnGivenHost | Status : SUCCESS ===
ok
Test Deploy Virtual Machine with no startVM parameter ... === TestName: test_01_deploy_vm_no_startvm | Status : SUCCESS ===
ok
Test Deploy Virtual Machine with startVM=true parameter ... === TestName: test_02_deploy_vm_startvm_true | Status : SUCCESS ===
ok
Test Deploy Virtual Machine with startVM=false parameter ... === TestName: test_03_deploy_vm_startvm_false | Status : SUCCESS ===
ok
Test Deploy Virtual Machine with startVM=false and attach volume ... === TestName: test_04_deploy_startvm_false_attach_volume |
Status : SUCCESS ===
ok
Test Deploy Virtual Machine with startVM=false and change service offering ... === TestName: test_05_deploy_startvm_false_change_so |
Status : SUCCESS ===
ok
Test Deploy Virtual Machine with startVM=false and ... === TestName: test_06_deploy_startvm_attach_detach | Status : SUCCESS ===
ok
Test Deploy Virtual Machine with startVM=false and attach ISO ... === TestName: test_07_deploy_startvm_attach_iso | Status : SUCCESS ===
ok
Test Deploy Virtual Machine with startVM=false and attach volume already attached to different machine ... === TestName:
test_08_deploy_attached_volume | Status : SUCCESS ===
ok
Test Stopped Virtual Machine's ROOT volume migration ... SKIP: No cluster with more than one primary storage pool to perform migrate
volume test
Test Deploy Virtual Machine with startVM=false & enabledpassword in ... === TestName: test_deploy_vm_password_enabled | Status :
SUCCESS ===
ok
Test Deploy Virtual Machine with no startVM parameter ... === TestName: test_01_deploy_vm_no_startvm | Status : SUCCESS ===
ok
Test Upload volume and attach to VM in stopped state ... === TestName: test_upload_attach_volume | Status : SUCCESS ===
ok
Test VM limit per account ... === TestName: test_vm_per_account | Status : SUCCESS ===
ok
----------------------------------------------------------------------
Ran 17 tests in 1834.202s
OK (SKIP=2)
Thanks,
Gaurav Aradhye
Re: Review Request 31181: CLOUDSTACK-8268: Code improvement -
test_stopped_vm.py
Posted by SrikanteswaraRao Talluri <sr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31181/#review73276
-----------------------------------------------------------
Ship it!
ba08229ff9a8246eddfc9e373dd4efdf35268013 master
- SrikanteswaraRao Talluri
On Feb. 20, 2015, 6:32 a.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31181/
> -----------------------------------------------------------
>
> (Updated Feb. 20, 2015, 6:32 a.m.)
>
>
> Review request for cloudstack and SrikanteswaraRao Talluri.
>
>
> Bugs: CLOUDSTACK-8268
> https://issues.apache.org/jira/browse/CLOUDSTACK-8268
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> 1. Read all the test data from test_data.py
> 2. Remove hard coded test data (Services class) from the test suite
> 3. Fix autopep8 issues
> 4. Move bootableVolume to configurableData section and make relevant changes in test case to read the data according to hypervisor
>
>
> Diffs
> -----
>
> test/integration/component/test_stopped_vm.py 1cefc07
> tools/marvin/marvin/config/test_data.py e8365ed
>
> Diff: https://reviews.apache.org/r/31181/diff/
>
>
> Testing
> -------
>
> Test Deploy HA enabled Virtual Machine with startvm=false ... === TestName: test_01_deploy_ha_vm_startvm_false | Status : SUCCESS ===
> ok
> Test Deploy HA enabled Virtual Machine from ISO ... SKIP: Bootable Iso URL not present in test data for xenserver
> Test Deploy HA enabled Virtual Machine from ISO with startvm=false ... === TestName: test_03_deploy_ha_vm_iso_startvm_false | Status :
> SUCCESS ===
> ok
> Test deploy VM on specific host ... === TestName: test_deployVmOnGivenHost | Status : SUCCESS ===
> ok
> Test Deploy Virtual Machine with no startVM parameter ... === TestName: test_01_deploy_vm_no_startvm | Status : SUCCESS ===
> ok
> Test Deploy Virtual Machine with startVM=true parameter ... === TestName: test_02_deploy_vm_startvm_true | Status : SUCCESS ===
> ok
> Test Deploy Virtual Machine with startVM=false parameter ... === TestName: test_03_deploy_vm_startvm_false | Status : SUCCESS ===
> ok
> Test Deploy Virtual Machine with startVM=false and attach volume ... === TestName: test_04_deploy_startvm_false_attach_volume |
> Status : SUCCESS ===
> ok
> Test Deploy Virtual Machine with startVM=false and change service offering ... === TestName: test_05_deploy_startvm_false_change_so |
> Status : SUCCESS ===
> ok
> Test Deploy Virtual Machine with startVM=false and ... === TestName: test_06_deploy_startvm_attach_detach | Status : SUCCESS ===
> ok
> Test Deploy Virtual Machine with startVM=false and attach ISO ... === TestName: test_07_deploy_startvm_attach_iso | Status : SUCCESS ===
> ok
> Test Deploy Virtual Machine with startVM=false and attach volume already attached to different machine ... === TestName:
> test_08_deploy_attached_volume | Status : SUCCESS ===
> ok
> Test Stopped Virtual Machine's ROOT volume migration ... SKIP: No cluster with more than one primary storage pool to perform migrate
> volume test
> Test Deploy Virtual Machine with startVM=false & enabledpassword in ... === TestName: test_deploy_vm_password_enabled | Status :
> SUCCESS ===
> ok
> Test Deploy Virtual Machine with no startVM parameter ... === TestName: test_01_deploy_vm_no_startvm | Status : SUCCESS ===
> ok
> Test Upload volume and attach to VM in stopped state ... === TestName: test_upload_attach_volume | Status : SUCCESS ===
> ok
> Test VM limit per account ... === TestName: test_vm_per_account | Status : SUCCESS ===
> ok
>
> ----------------------------------------------------------------------
> Ran 17 tests in 1834.202s
>
> OK (SKIP=2)
>
>
> Thanks,
>
> Gaurav Aradhye
>
>
Re: Review Request 31181: CLOUDSTACK-8268: Code improvement -
test_stopped_vm.py
Posted by Gaurav Aradhye <ga...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31181/
-----------------------------------------------------------
(Updated Feb. 20, 2015, 12:02 p.m.)
Review request for cloudstack and SrikanteswaraRao Talluri.
Bugs: CLOUDSTACK-8268
https://issues.apache.org/jira/browse/CLOUDSTACK-8268
Repository: cloudstack-git
Description
-------
1. Read all the test data from test_data.py
2. Remove hard coded test data (Services class) from the test suite
3. Fix autopep8 issues
4. Move bootableVolume to configurableData section and make relevant changes in test case to read the data according to hypervisor
Diffs (updated)
-----
test/integration/component/test_stopped_vm.py 1cefc07
tools/marvin/marvin/config/test_data.py e8365ed
Diff: https://reviews.apache.org/r/31181/diff/
Testing
-------
Test Deploy HA enabled Virtual Machine with startvm=false ... === TestName: test_01_deploy_ha_vm_startvm_false | Status : SUCCESS ===
ok
Test Deploy HA enabled Virtual Machine from ISO ... SKIP: Bootable Iso URL not present in test data for xenserver
Test Deploy HA enabled Virtual Machine from ISO with startvm=false ... === TestName: test_03_deploy_ha_vm_iso_startvm_false | Status :
SUCCESS ===
ok
Test deploy VM on specific host ... === TestName: test_deployVmOnGivenHost | Status : SUCCESS ===
ok
Test Deploy Virtual Machine with no startVM parameter ... === TestName: test_01_deploy_vm_no_startvm | Status : SUCCESS ===
ok
Test Deploy Virtual Machine with startVM=true parameter ... === TestName: test_02_deploy_vm_startvm_true | Status : SUCCESS ===
ok
Test Deploy Virtual Machine with startVM=false parameter ... === TestName: test_03_deploy_vm_startvm_false | Status : SUCCESS ===
ok
Test Deploy Virtual Machine with startVM=false and attach volume ... === TestName: test_04_deploy_startvm_false_attach_volume |
Status : SUCCESS ===
ok
Test Deploy Virtual Machine with startVM=false and change service offering ... === TestName: test_05_deploy_startvm_false_change_so |
Status : SUCCESS ===
ok
Test Deploy Virtual Machine with startVM=false and ... === TestName: test_06_deploy_startvm_attach_detach | Status : SUCCESS ===
ok
Test Deploy Virtual Machine with startVM=false and attach ISO ... === TestName: test_07_deploy_startvm_attach_iso | Status : SUCCESS ===
ok
Test Deploy Virtual Machine with startVM=false and attach volume already attached to different machine ... === TestName:
test_08_deploy_attached_volume | Status : SUCCESS ===
ok
Test Stopped Virtual Machine's ROOT volume migration ... SKIP: No cluster with more than one primary storage pool to perform migrate
volume test
Test Deploy Virtual Machine with startVM=false & enabledpassword in ... === TestName: test_deploy_vm_password_enabled | Status :
SUCCESS ===
ok
Test Deploy Virtual Machine with no startVM parameter ... === TestName: test_01_deploy_vm_no_startvm | Status : SUCCESS ===
ok
Test Upload volume and attach to VM in stopped state ... === TestName: test_upload_attach_volume | Status : SUCCESS ===
ok
Test VM limit per account ... === TestName: test_vm_per_account | Status : SUCCESS ===
ok
----------------------------------------------------------------------
Ran 17 tests in 1834.202s
OK (SKIP=2)
Thanks,
Gaurav Aradhye