[GitHub] [incubator-iceberg] rdsr opened a new pull request #207: Add external schema mappings for files written with name-based schemas #40

[GitBox <gi...@apache.org>]

rdsr opened a new pull request #207: Add external schema mappings for files written with name-based schemas #40
URL: https://github.com/apache/incubator-iceberg/pull/207
 
 
   Here's a first pass at implementing this.
   
   External mapping is maintained as a field name -> field id map. So each alias will be an different entry in the map with the same id.  
   
   `AssignFieldIds` assign field ids to fields. This visitor updates the schema instead of building a new schema with field ids. I felt this was OK. Let me know if this is not the case.
   
   
   TODOs
   1. Support schema insensitivity
   2. Add tests for aliasing 
   3. Maybe have a better testing strategy? . (The way I build the mapping seems a hack IMO)
   
   In code, Open questions I've added as TODOs. I'd appreciate to if we can discuss those in the comments

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org