You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2022/11/04 18:20:20 UTC

[commons-lang] branch master updated: Reuse own API

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-lang.git


The following commit(s) were added to refs/heads/master by this push:
     new ecd23d5e2 Reuse own API
ecd23d5e2 is described below

commit ecd23d5e207cd409d077347d2797b47bf9f75af2
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Fri Nov 4 14:20:14 2022 -0400

    Reuse own API
---
 src/main/java/org/apache/commons/lang3/Validate.java             | 3 +--
 src/main/java/org/apache/commons/lang3/time/FastDatePrinter.java | 7 +++----
 2 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/src/main/java/org/apache/commons/lang3/Validate.java b/src/main/java/org/apache/commons/lang3/Validate.java
index be26aa70e..c0e37d7b0 100644
--- a/src/main/java/org/apache/commons/lang3/Validate.java
+++ b/src/main/java/org/apache/commons/lang3/Validate.java
@@ -1163,8 +1163,7 @@ public class Validate {
     public static void isInstanceOf(final Class<?> type, final Object obj) {
         // TODO when breaking BC, consider returning obj
         if (!type.isInstance(obj)) {
-            throw new IllegalArgumentException(String.format(DEFAULT_IS_INSTANCE_OF_EX_MESSAGE, type.getName(),
-                    obj == null ? "null" : obj.getClass().getName()));
+            throw new IllegalArgumentException(String.format(DEFAULT_IS_INSTANCE_OF_EX_MESSAGE, type.getName(), ClassUtils.getName(obj, "null")));
         }
     }
 
diff --git a/src/main/java/org/apache/commons/lang3/time/FastDatePrinter.java b/src/main/java/org/apache/commons/lang3/time/FastDatePrinter.java
index 6ed587dae..d86b25e32 100644
--- a/src/main/java/org/apache/commons/lang3/time/FastDatePrinter.java
+++ b/src/main/java/org/apache/commons/lang3/time/FastDatePrinter.java
@@ -32,6 +32,7 @@ import java.util.TimeZone;
 import java.util.concurrent.ConcurrentHashMap;
 import java.util.concurrent.ConcurrentMap;
 
+import org.apache.commons.lang3.ClassUtils;
 import org.apache.commons.lang3.LocaleUtils;
 import org.apache.commons.lang3.exception.ExceptionUtils;
 
@@ -424,8 +425,7 @@ public class FastDatePrinter implements DatePrinter, Serializable {
         if (obj instanceof Long) {
             return format(((Long) obj).longValue(), toAppendTo);
         }
-        throw new IllegalArgumentException("Unknown class: " +
-            (obj == null ? "<null>" : obj.getClass().getName()));
+        throw new IllegalArgumentException("Unknown class: " + ClassUtils.getName(obj, "<null>"));
     }
 
     /**
@@ -445,8 +445,7 @@ public class FastDatePrinter implements DatePrinter, Serializable {
         if (obj instanceof Long) {
             return format(((Long) obj).longValue());
         }
-        throw new IllegalArgumentException("Unknown class: " +
-            (obj == null ? "<null>" : obj.getClass().getName()));
+        throw new IllegalArgumentException("Unknown class: " + ClassUtils.getName(obj, "<null>"));
     }
 
     /* (non-Javadoc)