You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lenya.apache.org by "Gregor J. Rothfuss" <gr...@apache.org> on 2005/05/09 05:16:12 UTC

changing the forrest pelt skin to get rid of js

<script src="skin/getBlank.js" language="javascript" 
type="text/javascript"></script><script src="skin/getMenu.js" 
language="javascript" type="text/javascript"></script><script 
src="skin/fontsize.js" language="javascript" 
type="text/javascript"></script>
</head>
<body onload="init()">
<script type="text/javascript">ndeSetTextSize();</script>


can we please get rid of these js in the pelt skin, or at least not 
include them when the skin properties are set to disable gimmicks like 
the font size thing? it's causing people's browsers to consume a lot of 
cpu apparently:

http://www.theserverside.com/tss?service=direct/0/PostNewsReply/postReply&sp=l33773&sp=F&sp=l169468#169451

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org


Re: changing the forrest pelt skin to get rid of js

Posted by Thorsten Scherler <th...@apache.org>.
On Mon, 2005-05-09 at 14:44 -0400, Gregor J. Rothfuss wrote:
> Thorsten Scherler wrote:
> 
> > I can understand that but it is not only in pelt but in all current
> > skins like this. ...and did you tested it yourself?
> 
> frankly, it's a toy feature that should go away completely, 

Hmm, it is not! It is there for accessibility reasons but if it is
causing problem then we need to have a closer look on it. 

> but that is 
> up to forrest. i haven't hit the problem myself yet.
> 

Me neither, we will keep an eye on it.

salu2
-- 
thorsten

"Together we stand, divided we fall!" 
Hey you (Pink Floyd)


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org


Re: changing the forrest pelt skin to get rid of js

Posted by "Gregor J. Rothfuss" <gr...@apache.org>.
Thorsten Scherler wrote:

> I can understand that but it is not only in pelt but in all current
> skins like this. ...and did you tested it yourself?

frankly, it's a toy feature that should go away completely, but that is 
up to forrest. i haven't hit the problem myself yet.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org


Re: changing the forrest pelt skin to get rid of js

Posted by Thorsten Scherler <th...@apache.org>.
On Mon, 2005-05-09 at 13:19 -0400, Gregor J. Rothfuss wrote:
> Thorsten Scherler wrote:
> 
> > yes we could but forrest:views are only included in 0.7 in the
> > whiteboard. ...but we can use it from there. 
> 
> i know that 0.7 is probably not stable yet, but this js bug hurts 
> visitors to our site, so i'd like to get it resolved asap.
> 

I can understand that but it is not only in pelt but in all current
skins like this. ...and did you tested it yourself?

> the alternative is to fork the pelt skin and rip it out in our copy for 
> the time being
> 

-1

We had that. It was not good and we should not do it.

Another would be to send a patch.
-- 
thorsten

"Together we stand, divided we fall!" 
Hey you (Pink Floyd)


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org


Re: changing the forrest pelt skin to get rid of js

Posted by "Gregor J. Rothfuss" <gr...@apache.org>.
Thorsten Scherler wrote:

> yes we could but forrest:views are only included in 0.7 in the
> whiteboard. ...but we can use it from there. 

i know that 0.7 is probably not stable yet, but this js bug hurts 
visitors to our site, so i'd like to get it resolved asap.

the alternative is to fork the pelt skin and rip it out in our copy for 
the time being


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org


Re: changing the forrest pelt skin to get rid of js

Posted by Thorsten Scherler <th...@apache.org>.
On Mon, 2005-05-09 at 12:31 -0400, Gregor J. Rothfuss wrote:
> Thorsten Scherler wrote:
> > Wrong list. ;-)
> > 
> > You can send a patch (feature request) but this is low priority because
> > with forrest:views only code will be generated that is needed. With
> > other words it is fixed in views which is the forrest future of
> > skinning, I wouldn't focus my time on that.
> 
> is that gonna be part of 0.7, 

no

> and if yes, can we switch the build to 0.7 ?
> 

yes we could but forrest:views are only included in 0.7 in the
whiteboard. ...but we can use it from there. 
-- 
thorsten

"Together we stand, divided we fall!" 
Hey you (Pink Floyd)


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org


Re: changing the forrest pelt skin to get rid of js

Posted by "Gregor J. Rothfuss" <gr...@apache.org>.
Thorsten Scherler wrote:
> Wrong list. ;-)
> 
> You can send a patch (feature request) but this is low priority because
> with forrest:views only code will be generated that is needed. With
> other words it is fixed in views which is the forrest future of
> skinning, I wouldn't focus my time on that.

is that gonna be part of 0.7, and if yes, can we switch the build to 0.7 ?

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org


Re: changing the forrest pelt skin to get rid of js

Posted by Thorsten Scherler <th...@apache.org>.
Wrong list. ;-)

You can send a patch (feature request) but this is low priority because
with forrest:views only code will be generated that is needed. With
other words it is fixed in views which is the forrest future of
skinning, I wouldn't focus my time on that.

salu2

On Sun, 2005-05-08 at 23:16 -0400, Gregor J. Rothfuss wrote:
> <script src="skin/getBlank.js" language="javascript" 
> type="text/javascript"></script><script src="skin/getMenu.js" 
> language="javascript" type="text/javascript"></script><script 
> src="skin/fontsize.js" language="javascript" 
> type="text/javascript"></script>
> </head>
> <body onload="init()">
> <script type="text/javascript">ndeSetTextSize();</script>
> 
> 
> can we please get rid of these js in the pelt skin, or at least not 
> include them when the skin properties are set to disable gimmicks like 
> the font size thing? it's causing people's browsers to consume a lot of 
> cpu apparently:
> 
> http://www.theserverside.com/tss?service=direct/0/PostNewsReply/postReply&sp=l33773&sp=F&sp=l169468#169451
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
> For additional commands, e-mail: dev-help@lenya.apache.org
> 
-- 
thorsten

"Together we stand, divided we fall!" 
Hey you (Pink Floyd)


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org