You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Jianxia Chen <jc...@pivotal.io> on 2016/03/18 23:50:12 UTC
Review Request 45058: GEODE-1107 CI failure:
RestAPIsWithSSLDUnitTest.testSimpleSSL
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45058/
-----------------------------------------------------------
Review request for geode, Bruce Schuchardt, Hitesh Khamesra, and Udo Kohlmeyer.
Repository: geode
Description
-------
Set jmx-manager-port to 0 so that it does not allow remote client connections. Hence avoid starting the agent. Then there is no worry about the port already in use for the agent. HTTP service is still started though.
Diffs
-----
geode-assembly/src/test/java/com/gemstone/gemfire/rest/internal/web/controllers/RestAPIsWithSSLDUnitTest.java 29aab32
Diff: https://reviews.apache.org/r/45058/diff/
Testing
-------
RestAPIsWithSSLDUnitTest
Thanks,
Jianxia Chen
Re: Review Request 45058: GEODE-1107 CI failure:
RestAPIsWithSSLDUnitTest.testSimpleSSL
Posted by Jianxia Chen <jc...@pivotal.io>.
> On March 21, 2016, 5:58 p.m., Udo Kohlmeyer wrote:
> > geode-assembly/src/test/java/com/gemstone/gemfire/rest/internal/web/controllers/RestAPIsWithSSLDUnitTest.java, lines 383-386
> > <https://reviews.apache.org/r/45058/diff/1/?file=1306972#file1306972line383>
> >
> > The jmx-manager + jmx-manager-start = true properties must be conflicting with the port=0. What would the behaviour be?
> >
> > I would imagine that we either turn the jmx off completely or handle the port allocation in a different manner if more than 1 jmx server is statrted on the same machine.
The test itself does not use any client to connect the JMX manager. So setting the port to 0 should have no harm. I guess the original purpose of starting JMX manager is to see whether it works fine with the REST API code (both management and dev REST API).
If the JMX manager is turned off, the test also passes. But I'd prefer keeping the JMX manager on. There must be some reason to start JMX manager in the test.
- Jianxia
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45058/#review124602
-----------------------------------------------------------
On March 18, 2016, 10:50 p.m., Jianxia Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45058/
> -----------------------------------------------------------
>
> (Updated March 18, 2016, 10:50 p.m.)
>
>
> Review request for geode, Bruce Schuchardt, Hitesh Khamesra, and Udo Kohlmeyer.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Set jmx-manager-port to 0 so that it does not allow remote client connections. Hence avoid starting the agent. Then there is no worry about the port already in use for the agent. HTTP service is still started though.
>
>
> Diffs
> -----
>
> geode-assembly/src/test/java/com/gemstone/gemfire/rest/internal/web/controllers/RestAPIsWithSSLDUnitTest.java 29aab32
>
> Diff: https://reviews.apache.org/r/45058/diff/
>
>
> Testing
> -------
>
> RestAPIsWithSSLDUnitTest
>
>
> Thanks,
>
> Jianxia Chen
>
>
Re: Review Request 45058: GEODE-1107 CI failure:
RestAPIsWithSSLDUnitTest.testSimpleSSL
Posted by Udo Kohlmeyer <uk...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45058/#review124602
-----------------------------------------------------------
geode-assembly/src/test/java/com/gemstone/gemfire/rest/internal/web/controllers/RestAPIsWithSSLDUnitTest.java (lines 383 - 386)
<https://reviews.apache.org/r/45058/#comment187215>
The jmx-manager + jmx-manager-start = true properties must be conflicting with the port=0. What would the behaviour be?
I would imagine that we either turn the jmx off completely or handle the port allocation in a different manner if more than 1 jmx server is statrted on the same machine.
- Udo Kohlmeyer
On March 18, 2016, 10:50 p.m., Jianxia Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45058/
> -----------------------------------------------------------
>
> (Updated March 18, 2016, 10:50 p.m.)
>
>
> Review request for geode, Bruce Schuchardt, Hitesh Khamesra, and Udo Kohlmeyer.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Set jmx-manager-port to 0 so that it does not allow remote client connections. Hence avoid starting the agent. Then there is no worry about the port already in use for the agent. HTTP service is still started though.
>
>
> Diffs
> -----
>
> geode-assembly/src/test/java/com/gemstone/gemfire/rest/internal/web/controllers/RestAPIsWithSSLDUnitTest.java 29aab32
>
> Diff: https://reviews.apache.org/r/45058/diff/
>
>
> Testing
> -------
>
> RestAPIsWithSSLDUnitTest
>
>
> Thanks,
>
> Jianxia Chen
>
>