You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ant.apache.org by bu...@apache.org on 2022/01/21 14:48:35 UTC

[Bug 65833] New: junitlauncher legacy-xml reporter should escape ]]> when writing CDATA

https://bz.apache.org/bugzilla/show_bug.cgi?id=65833

            Bug ID: 65833
           Summary: junitlauncher legacy-xml reporter should escape ]]>
                    when writing CDATA
           Product: Ant
           Version: 1.10.12
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Optional Tasks
          Assignee: notifications@ant.apache.org
          Reporter: taylor.smock@kaart.com
  Target Milestone: ---

Sample invalid CDATA:
```
<![CDATA[org.opentest4j.AssertionFailedError: Conversion tracks-extensions.gpx
-> tracks-extensions.osm didn't match! ==> expected:
<[128:[gpx:extension:test:segment:tag=Segment extension,
gpx:extension:test:tag=Track extension, gpxx:Di  splayColor=Red],
13:[gpxd:color=#00FF00], 238:[gpxd:color=#0000FF], 9:[], 9:[]]> but was:
<[128:[gpx:extension:gpxx:TrackExtension:DisplayColor=Red,
gpx:extension:test:segment:tag=Segment extension, gpx:extension:test:tag=Track
extensio  n], 13:[gpx:extension:gpxd:color=#00FF00],
238:[gpx:extension:gpxd:color=#0000FF], 9:[], 9:[]]>
      at
org.openstreetmap.josm.gui.layer.gpx.ConvertToDataLayerActionTest.testFromTrack(ConvertToDataLayerActionTest.java:144)
      at
org.openstreetmap.josm.gui.layer.gpx.ConvertToDataLayerActionTest.testFromTrack(ConvertToDataLayerActionTest.java:75)
]]>
```
Note the multiple CDATA endings, `]]>`.

This was fixed in JUnit5 (see https://github.com/junit-team/junit5/issues/1225
), but since `ant` has its own reporting implementation, this will not
automatically be fixed on dependency updates.

It does appear that JUnit5 took the approach of replacing `]]>` with
`]]]]><![CDATA[>` (essentially making multiple CDATA segments).

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 65833] junitlauncher legacy-xml reporter should escape ]]> when writing CDATA

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=65833

--- Comment #1 from Taylor Smock <ta...@kaart.com> ---
PR with fix made at https://github.com/apache/ant/pull/175 .

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 65833] junitlauncher legacy-xml reporter should escape ]]> when writing CDATA

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=65833

Jaikiran Pai <ja...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED
   Target Milestone|---                         |1.10.13

--- Comment #2 from Jaikiran Pai <ja...@apache.org> ---
Changes from the PR have been merged. Marking as resolved.

-- 
You are receiving this mail because:
You are the assignee for the bug.