[GitHub] [superset] baz-bakerhughes commented on a diff in pull request #19837: feat(charts): allow query mutator to update queries after splitting original sql

[GitBox <gi...@apache.org>]

baz-bakerhughes commented on code in PR #19837:
URL: https://github.com/apache/superset/pull/19837#discussion_r932221031


##########
superset/models/core.py:
##########
@@ -415,7 +415,11 @@ def get_df(  # pylint: disable=too-many-locals
         mutator: Optional[Callable[[pd.DataFrame], None]] = None,
     ) -> pd.DataFrame:
         sqls = self.db_engine_spec.parse_sql(sql)
-        engine = self.get_sqla_engine(schema)
+
+        engine = self.get_sqla_engine(schema=schema, user_name=username)

Review Comment:
   @john-bodley  @nytai  How can we get this to the next level our colleague was an intern whose internship has ended and we would like to get this merged into main superset. Apologies for my ignorance on what steps are pending on our part if any.  But as none of us are approved reviewers we need a bit of guidance on how to get this into main.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org