[GitHub] [bookkeeper] pkumar-singh commented on pull request #2812: ISSUE #2640: BP-43 Migrate to gradle all other tests

[GitBox <gi...@apache.org>]

pkumar-singh commented on pull request #2812:
URL: https://github.com/apache/bookkeeper/pull/2812#issuecomment-946933669


   > LGTM, really great work!
   > 
   > Did you try to compare dist artifact built with maven and gradle? My mainly concern is we can mismatch a dependency's version or similar, and the final jars will be unintentionally different
   
   Absolutely.!
   Basically as part of PR build following script runs. 
   dev/check-all-licenses-gradle
   What it does is. Untar the tar ball created by gradle. That tar ball contains all bookkeeper jars as well as dependencies jars.
   
   Now script matches each jar in the tar ball with the one mentioned here
   https://github.com/apache/bookkeeper/blob/master/bookkeeper-dist/src/main/resources/LICENSE-server.bin.txt
   
   Here https://github.com/apache/bookkeeper/blob/master/bookkeeper-dist/src/main/resources/LICENSE-all.bin.txt
   
   And here https://github.com/apache/bookkeeper/blob/master/bookkeeper-dist/src/main/resources/NOTICE-bkctl.bin.txt
   
   Script also ensure that tar ball does not pack any extra jar, in addition to ensuring exact version with the files mentioned above.
   
   Moreover, I have also manually untared the tar ball generated by gradle and maven and check one by one manually to verify they pack same dependencies. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org