You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "thswlsqls (via GitHub)" <gi...@apache.org> on 2026/08/06 10:33:39 UTC

[PR] [hive] Normalize column comments written to Hive metastore [paimon]

thswlsqls opened a new pull request, #9073:
URL: https://github.com/apache/paimon/pull/9073

   ### Purpose
   
   fix #9072
   
   - `HiveCatalog` passed `DataField.description()` to `FieldSchema` unchanged, so a comment longer than 256 characters made the metastore reject the `COLUMNS_V2` insert and fail `CREATE TABLE`.
   - Comments now go through the helper `IcebergHiveMetadataCommitter` already uses (#8223, #8918), moved to `HiveTableUtils` so both callers share it.
   - Only `COLUMNS_V2` comments are normalized; partition keys use `PARTITION_KEYS.PKEY_COMMENT`, which allows longer values, and stay untouched.
   - Behavior change: short comments containing newlines are now stored with newlines replaced by spaces, consistent with #8918.
   - The Paimon schema file still keeps the original comment.
   
   ### Tests
   
   - Added `HiveCatalogTest#testCreateTableWithLongColumnComment` (300-character comment with a newline: create succeeds, the mirror is truncated to 255 characters, Paimon keeps the original) and `#testCreateTableWithLongPartitionKeyComment`.
   - `mvn -pl paimon-hive/paimon-hive-catalog -DfailIfNoTests=false clean install` on JDK 11 — 76 tests passed.
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [hive] Normalize column comments written to Hive metastore [paimon]

Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi merged PR #9073:
URL: https://github.com/apache/paimon/pull/9073


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [hive] Normalize column comments written to Hive metastore [paimon]

Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on PR #9073:
URL: https://github.com/apache/paimon/pull/9073#issuecomment-5205835389

   +1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org