You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pinot.apache.org by GitBox <gi...@apache.org> on 2018/11/27 23:11:22 UTC
[GitHub] codecov-io edited a comment on issue #3336: Add metadata info and
metric when querying non-existing columns
codecov-io edited a comment on issue #3336: Add metadata info and metric when querying non-existing columns
URL: https://github.com/apache/incubator-pinot/pull/3336#issuecomment-442231005
# [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3336?src=pr&el=h1) Report
> Merging [#3336](https://codecov.io/gh/apache/incubator-pinot/pull/3336?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/4f5b2ddafcd2f617675812f0432b2878ee1d7552?src=pr&el=desc) will **increase** coverage by `0.04%`.
> The diff coverage is `93.54%`.
[](https://codecov.io/gh/apache/incubator-pinot/pull/3336?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3336 +/- ##
============================================
+ Coverage 70.8% 70.84% +0.04%
Complexity 4 4
============================================
Files 997 997
Lines 45760 45784 +24
Branches 6135 6139 +4
============================================
+ Hits 32400 32437 +37
+ Misses 11235 11219 -16
- Partials 2125 2128 +3
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/3336?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...inot/core/query/pruner/PartitionSegmentPruner.java](https://codecov.io/gh/apache/incubator-pinot/pull/3336/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL3F1ZXJ5L3BydW5lci9QYXJ0aXRpb25TZWdtZW50UHJ1bmVyLmphdmE=) | `80% <0%> (-2.76%)` | `0 <0> (ø)` | |
| [...n/pinot/core/query/reduce/BrokerReduceService.java](https://codecov.io/gh/apache/incubator-pinot/pull/3336/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL3F1ZXJ5L3JlZHVjZS9Ccm9rZXJSZWR1Y2VTZXJ2aWNlLmphdmE=) | `80.07% <100%> (+0.4%)` | `0 <0> (ø)` | :arrow_down: |
| [.../pinot/core/query/pruner/SegmentPrunerService.java](https://codecov.io/gh/apache/incubator-pinot/pull/3336/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL3F1ZXJ5L3BydW5lci9TZWdtZW50UHJ1bmVyU2VydmljZS5qYXZh) | `100% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...t/common/response/broker/BrokerResponseNative.java](https://codecov.io/gh/apache/incubator-pinot/pull/3336/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2xpbmtlZGluL3Bpbm90L2NvbW1vbi9yZXNwb25zZS9icm9rZXIvQnJva2VyUmVzcG9uc2VOYXRpdmUuamF2YQ==) | `89.01% <100%> (+0.5%)` | `0 <0> (ø)` | :arrow_down: |
| [...com/linkedin/pinot/common/metrics/ServerMeter.java](https://codecov.io/gh/apache/incubator-pinot/pull/3336/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2xpbmtlZGluL3Bpbm90L2NvbW1vbi9tZXRyaWNzL1NlcnZlck1ldGVyLmphdmE=) | `100% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...core/query/executor/ServerQueryExecutorV1Impl.java](https://codecov.io/gh/apache/incubator-pinot/pull/3336/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL3F1ZXJ5L2V4ZWN1dG9yL1NlcnZlclF1ZXJ5RXhlY3V0b3JWMUltcGwuamF2YQ==) | `80.32% <93.75%> (+1.42%)` | `0 <0> (ø)` | :arrow_down: |
| [...e/operator/dociditerators/MVScanDocIdIterator.java](https://codecov.io/gh/apache/incubator-pinot/pull/3336/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL29wZXJhdG9yL2RvY2lkaXRlcmF0b3JzL01WU2NhbkRvY0lkSXRlcmF0b3IuamF2YQ==) | `45.45% <0%> (-15.16%)` | `0% <0%> (ø)` | |
| [...impl/dictionary/DoubleOnHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/3336/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL3JlYWx0aW1lL2ltcGwvZGljdGlvbmFyeS9Eb3VibGVPbkhlYXBNdXRhYmxlRGljdGlvbmFyeS5qYXZh) | `68.88% <0%> (-13.34%)` | `0% <0%> (ø)` | |
| [...e/impl/dictionary/LongOnHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/3336/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL3JlYWx0aW1lL2ltcGwvZGljdGlvbmFyeS9Mb25nT25IZWFwTXV0YWJsZURpY3Rpb25hcnkuamF2YQ==) | `88.88% <0%> (-6.67%)` | `0% <0%> (ø)` | |
| [.../impl/dictionary/FloatOnHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/3336/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL3JlYWx0aW1lL2ltcGwvZGljdGlvbmFyeS9GbG9hdE9uSGVhcE11dGFibGVEaWN0aW9uYXJ5LmphdmE=) | `80% <0%> (-6.67%)` | `0% <0%> (ø)` | |
| ... and [27 more](https://codecov.io/gh/apache/incubator-pinot/pull/3336/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3336?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3336?src=pr&el=footer). Last update [4f5b2dd...60cf509](https://codecov.io/gh/apache/incubator-pinot/pull/3336?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pinot.apache.org
For additional commands, e-mail: dev-help@pinot.apache.org