You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@sling.apache.org by fm...@apache.org on 2008/03/04 15:44:47 UTC
svn commit: r633495 - /incubator/sling/trunk/pom.xml
Author: fmeschbe
Date: Tue Mar 4 06:44:45 2008
New Revision: 633495
URL: http://svn.apache.org/viewvc?rev=633495&view=rev
Log:
SLING-189 fix references to new and removed modules in reactor pom
Modified:
incubator/sling/trunk/pom.xml
Modified: incubator/sling/trunk/pom.xml
URL: http://svn.apache.org/viewvc/incubator/sling/trunk/pom.xml?rev=633495&r1=633494&r2=633495&view=diff
==============================================================================
--- incubator/sling/trunk/pom.xml (original)
+++ incubator/sling/trunk/pom.xml Tue Mar 4 06:44:45 2008
@@ -116,8 +116,7 @@
<!-- Launcher -->
<module>launchpad/launchpad-content</module>
- <module>launcher/app</module>
- <module>launcher/webapp</module>
+ <module>launchpad/app</module>
</modules>
<distributionManagement>
Re: [SLING-189] Launcher and Launchpad merge
Posted by Carsten Ziegeler <cz...@apache.org>.
Felix Meschberger wrote:
> Hi,
>
> Am Dienstag, den 04.03.2008, 17:29 +0100 schrieb Bertrand Delacretaz:
>> On Tue, Mar 4, 2008 at 4:33 PM, Carsten Ziegeler <cz...@apache.org> wrote:
>>
>>> ... +1 for renaming - same applies for the new apt modules....
>> +1 as well, and I have renamed the extensions/apt modules as suggested
>> - please update continuum accordingly ;-)
>
> Ok, and I did launchpad-* ... another fix to continuum registration
> required ;-)
>
Done (and I think title #8 from the same album I mentioned to Bertrand
says it all) :)
Carsten
--
Carsten Ziegeler
cziegeler@apache.org
Re: [SLING-189] Launcher and Launchpad merge
Posted by Felix Meschberger <fm...@gmail.com>.
Hi,
Am Dienstag, den 04.03.2008, 17:29 +0100 schrieb Bertrand Delacretaz:
> On Tue, Mar 4, 2008 at 4:33 PM, Carsten Ziegeler <cz...@apache.org> wrote:
>
> > ... +1 for renaming - same applies for the new apt modules....
>
> +1 as well, and I have renamed the extensions/apt modules as suggested
> - please update continuum accordingly ;-)
Ok, and I did launchpad-* ... another fix to continuum registration
required ;-)
Thanks and Regards
Felix
Re: [SLING-189] Launcher and Launchpad merge
Posted by Carsten Ziegeler <cz...@apache.org>.
Bertrand Delacretaz wrote:
> On Tue, Mar 4, 2008 at 5:50 PM, Carsten Ziegeler <cz...@apache.org> wrote:
>> ... Done and please see title #15 of the Very Best of The Smiths...
>
> I was going to search Google for that, but I'm not sure if that joke
> is funny anymore ;-)
>
:)
Carsten
--
Carsten Ziegeler
cziegeler@apache.org
Re: [SLING-189] Launcher and Launchpad merge
Posted by Bertrand Delacretaz <bd...@apache.org>.
On Tue, Mar 4, 2008 at 5:50 PM, Carsten Ziegeler <cz...@apache.org> wrote:
> ... Done and please see title #15 of the Very Best of The Smiths...
I was going to search Google for that, but I'm not sure if that joke
is funny anymore ;-)
-Bertrand
Re: [SLING-189] Launcher and Launchpad merge
Posted by Carsten Ziegeler <cz...@apache.org>.
Bertrand Delacretaz wrote:
> On Tue, Mar 4, 2008 at 4:33 PM, Carsten Ziegeler <cz...@apache.org> wrote:
>
>> ... +1 for renaming - same applies for the new apt modules....
>
> +1 as well, and I have renamed the extensions/apt modules as suggested
> - please update continuum accordingly ;-)
>
Done and please see title #15 of the Very Best of The Smiths...
:)
Carsten
--
Carsten Ziegeler
cziegeler@apache.org
Re: [SLING-189] Launcher and Launchpad merge
Posted by Bertrand Delacretaz <bd...@apache.org>.
On Tue, Mar 4, 2008 at 4:33 PM, Carsten Ziegeler <cz...@apache.org> wrote:
> ... +1 for renaming - same applies for the new apt modules....
+1 as well, and I have renamed the extensions/apt modules as suggested
- please update continuum accordingly ;-)
-Bertrand
Re: [SLING-189] Launcher and Launchpad merge
Posted by Carsten Ziegeler <cz...@apache.org>.
Felix Meschberger wrote:
> Hi all,
>
> This is just to inform you all, that I finally managed to merge the
> former launcher modules app and webapp into launchpad. The launcher/app
> module is now the launchpad/app module while the launcher/webapp stuff
> has been merged into the launchpad/launchpad-webapp module.
Great
>
> Except for a ujax move test, all integration tests seem to run. I will
> investigate the last failing test shortly.
>
> One question remains: should we have the "launchpad-" prefix in the
> folder names of the launchpad modules or not ? Given the other modules,
> which are not prefixed with their parent folder names, I would suggest
> to rename launchpad/launchpad-webapp and launchpad/launchpad-content
> into launchpad/webapp and launchpad/content, resp. [ This has no
> influence on the bundle symbolic names and project names, it is just the
> folder names ].
+1 for renaming - same applies for the new apt modules.
>
> Thanks, I just want to ask you to remove these (and instead add the new
> launchpad/app module).
>
Yepp, I added this one as well.
Carsten
--
Carsten Ziegeler
cziegeler@apache.org
[SLING-189] Launcher and Launchpad merge (was: svn commit: r633495
- /incubator/sling/trunk/pom.xml)
Posted by Felix Meschberger <fm...@gmail.com>.
Hi all,
This is just to inform you all, that I finally managed to merge the
former launcher modules app and webapp into launchpad. The launcher/app
module is now the launchpad/app module while the launcher/webapp stuff
has been merged into the launchpad/launchpad-webapp module.
Except for a ujax move test, all integration tests seem to run. I will
investigate the last failing test shortly.
One question remains: should we have the "launchpad-" prefix in the
folder names of the launchpad modules or not ? Given the other modules,
which are not prefixed with their parent folder names, I would suggest
to rename launchpad/launchpad-webapp and launchpad/launchpad-content
into launchpad/webapp and launchpad/content, resp. [ This has no
influence on the bundle symbolic names and project names, it is just the
folder names ].
WDYT ?
Am Dienstag, den 04.03.2008, 15:50 +0100 schrieb Carsten Ziegeler:
> I removed the two projects from continuum as well.
Thanks, I just want to ask you to remove these (and instead add the new
launchpad/app module).
Regards
Felix
Re: svn commit: r633495 - /incubator/sling/trunk/pom.xml
Posted by Carsten Ziegeler <cz...@apache.org>.
Bertrand Delacretaz wrote:
> On Tue, Mar 4, 2008 at 3:50 PM, Carsten Ziegeler <cz...@apache.org> wrote:
>> I removed the two projects from continuum as well.
>
> Thanks - and in the meantime there's more work for you ;-)
>
Thanks :)
Done
Carsten
> + <!-- Extensions -->
> + <module>extensions/apt/apt-parser</module>
> + <module>extensions/apt/apt-servlet</module>
> +
>
> -Bertrand
>
--
Carsten Ziegeler
cziegeler@apache.org
Re: svn commit: r633495 - /incubator/sling/trunk/pom.xml
Posted by Bertrand Delacretaz <bd...@apache.org>.
On Tue, Mar 4, 2008 at 3:50 PM, Carsten Ziegeler <cz...@apache.org> wrote:
> I removed the two projects from continuum as well.
Thanks - and in the meantime there's more work for you ;-)
+ <!-- Extensions -->
+ <module>extensions/apt/apt-parser</module>
+ <module>extensions/apt/apt-servlet</module>
+
-Bertrand
Re: svn commit: r633495 - /incubator/sling/trunk/pom.xml
Posted by Carsten Ziegeler <cz...@apache.org>.
I removed the two projects from continuum as well.
Carsten
fmeschbe@apache.org wrote:
> Author: fmeschbe
> Date: Tue Mar 4 06:44:45 2008
> New Revision: 633495
>
> URL: http://svn.apache.org/viewvc?rev=633495&view=rev
> Log:
> SLING-189 fix references to new and removed modules in reactor pom
>
> Modified:
> incubator/sling/trunk/pom.xml
>
> Modified: incubator/sling/trunk/pom.xml
> URL: http://svn.apache.org/viewvc/incubator/sling/trunk/pom.xml?rev=633495&r1=633494&r2=633495&view=diff
> ==============================================================================
> --- incubator/sling/trunk/pom.xml (original)
> +++ incubator/sling/trunk/pom.xml Tue Mar 4 06:44:45 2008
> @@ -116,8 +116,7 @@
>
> <!-- Launcher -->
> <module>launchpad/launchpad-content</module>
> - <module>launcher/app</module>
> - <module>launcher/webapp</module>
> + <module>launchpad/app</module>
>
> </modules>
> <distributionManagement>
>
>
>
--
Carsten Ziegeler
cziegeler@apache.org