You are viewing a plain text version of this content. The canonical link for it is here.
Posted to log4j-dev@logging.apache.org by Nick Williams <ni...@nicholaswilliams.net> on 2014/02/09 07:22:49 UTC
Level
Gary,
One of your commits tonight changed all of the methods in Level from being final to being non-final. This is not what we agreed upon. Why did you make this change? Was this one of the auto-refactor changes? I've noticed a lot of cleanup tonight that smells like that. :-)
Nick
---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org
Re: Level
Posted by Gary Gregory <ga...@gmail.com>.
On Sun, Feb 9, 2014 at 1:38 AM, Nick Williams <nicholas@nicholaswilliams.net
> wrote:
> Ahh. The class was originally abstract, hence why the methods were final.
> I see now why that's not needed. My bad.
>
> N
>
>
Yeah, lots of changes in this area. Good thing we're cutting a non-GA :)
Gary
> On Feb 9, 2014, at 12:34 AM, Gary Gregory wrote:
>
> On Sun, Feb 9, 2014 at 1:22 AM, Nick Williams <
> nicholas@nicholaswilliams.net> wrote:
>
>> Gary,
>>
>> One of your commits tonight changed all of the methods in Level from
>> being final to being non-final.
>
>
> Uh, the class is final, hence all the method are final...
>
> Gary
>
>
>> This is not what we agreed upon. Why did you make this change? Was this
>> one of the auto-refactor changes? I've noticed a lot of cleanup tonight
>> that smells like that. :-)
>>
>> Nick
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
>> For additional commands, e-mail: log4j-dev-help@logging.apache.org
>>
>>
>
>
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> Java Persistence with Hibernate, Second Edition<http://www.manning.com/bauer3/>
> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> Spring Batch in Action <http://www.manning.com/templier/>
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>
>
>
--
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Re: Level
Posted by Nick Williams <ni...@nicholaswilliams.net>.
Ahh. The class was originally abstract, hence why the methods were final. I see now why that's not needed. My bad.
N
On Feb 9, 2014, at 12:34 AM, Gary Gregory wrote:
> On Sun, Feb 9, 2014 at 1:22 AM, Nick Williams <ni...@nicholaswilliams.net> wrote:
> Gary,
>
> One of your commits tonight changed all of the methods in Level from being final to being non-final.
>
> Uh, the class is final, hence all the method are final...
>
> Gary
>
> This is not what we agreed upon. Why did you make this change? Was this one of the auto-refactor changes? I've noticed a lot of cleanup tonight that smells like that. :-)
>
> Nick
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
> For additional commands, e-mail: log4j-dev-help@logging.apache.org
>
>
>
>
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> Java Persistence with Hibernate, Second Edition
> JUnit in Action, Second Edition
> Spring Batch in Action
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
Re: Level
Posted by Gary Gregory <ga...@gmail.com>.
On Sun, Feb 9, 2014 at 1:22 AM, Nick Williams <nicholas@nicholaswilliams.net
> wrote:
> Gary,
>
> One of your commits tonight changed all of the methods in Level from being
> final to being non-final.
Uh, the class is final, hence all the method are final...
Gary
> This is not what we agreed upon. Why did you make this change? Was this
> one of the auto-refactor changes? I've noticed a lot of cleanup tonight
> that smells like that. :-)
>
> Nick
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
> For additional commands, e-mail: log4j-dev-help@logging.apache.org
>
>
--
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory