You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/08/30 07:45:30 UTC
[GitHub] [spark] HyukjinKwon commented on a diff in pull request #37722: [SPARK-40271][PYTHON] Support list type for `pyspark.sql.functions.lit`.
HyukjinKwon commented on code in PR #37722:
URL: https://github.com/apache/spark/pull/37722#discussion_r958120567
##########
python/pyspark/sql/functions.py:
##########
@@ -149,7 +149,17 @@ def lit(col: Any) -> Column:
+------+---+
| 5| 0|
+------+---+
+
+ Support for list
Review Comment:
```suggestion
Create a literal from a list.
```
##########
python/pyspark/sql/functions.py:
##########
@@ -149,7 +149,17 @@ def lit(col: Any) -> Column:
+------+---+
| 5| 0|
+------+---+
+
+ Support for list
Review Comment:
Can you fix "Python primitive type." in the docstring above?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org