You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/04/22 13:53:15 UTC

[GitHub] [superset] michael-s-molina commented on a change in pull request #14199: chore: Removes ColorSchemeControl.less

michael-s-molina commented on a change in pull request #14199:
URL: https://github.com/apache/superset/pull/14199#discussion_r618422218



##########
File path: superset-frontend/src/explore/components/controls/ColorSchemeControl.jsx
##########
@@ -74,11 +72,26 @@ export default class ColorSchemeControl extends React.PureComponent {
 
     return (
       <Tooltip id={`${currentScheme.id}-tooltip`} title={currentScheme.label}>
-        <ul className="color-scheme-container" data-test={currentScheme.id}>
+        <ul
+          css={{

Review comment:
       @geido [Here](https://github.com/apache/superset/pull/12920#discussion_r569471680) is the discussion about the css vs styled 😉. One idea that @rusackas and I were talking about is to create a document of our patterns where everyone can discuss and collaborate.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org