[GitHub] [spark] srielau commented on a diff in pull request #40884: [SPARK-43205] IDENTIFIER() clause

["srielau (via GitHub)" <gi...@apache.org>]

srielau commented on code in PR #40884:
URL: https://github.com/apache/spark/pull/40884#discussion_r1178121404


##########
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBaseParser.g4:
##########
@@ -798,9 +798,19 @@ multipartIdentifierList
     ;
 
 multipartIdentifier
-    : parts+=errorCapturingIdentifier (DOT parts+=errorCapturingIdentifier)*
+    : parts+=errorCapturingIdentifierWithTemplate (DOT parts+=errorCapturingIdentifierWithTemplate)*
     ;
 
+errorCapturingIdentifierWithTemplate
+   : identifierClause
+   | ident = errorCapturingIdentifier
+   ;
+
+errorCapturingSingleIdentifierWithTemplate

Review Comment:
   The SingleIdentifier versions raise an error if the string literal passed to IDENTIFIER() parses as a qualified name.
   They also produce a String. Where the others produce a Seq[String]



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org