You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@camel.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/05/11 21:16:00 UTC
[jira] [Commented] (CAMEL-12506) SqsProducer doesn't support Boolean attributes

    [ https://issues.apache.org/jira/browse/CAMEL-12506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16472674#comment-16472674 ] 

ASF GitHub Bot commented on CAMEL-12506:
----------------------------------------

GitHub user candrews opened a pull request:

    https://github.com/apache/camel/pull/2337

    CAMEL-12506 and CAMEL-12507: SQS support for boolean and custom number types

    https://issues.apache.org/jira/browse/CAMEL-12506 SqsProducer doesn't support Boolean attributes
    https://issues.apache.org/jira/browse/CAMEL-12507 SqsProducer support for Number custom data types

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/candrews/camel patch-3

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/camel/pull/2337.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2337
    
----
commit c13ea12e60c8a3b366a4a654a9371ad94ec3c1e6
Author: Craig Andrews <ca...@...>
Date:   2018-05-11T20:50:17Z

    CAMEL-12506: SQS Producer support for boolean attributes
    
    If a header of type `Boolean` is provided, map it to an SQS `MessageAttributeValue` of type "Number" with the`MessageAttributeValue`'s StringValue being "1" for true and "0" for false.
    
    This behavior matches that of amazon-sqs-java-messaging-lib: https://github.com/awslabs/amazon-sqs-java-messaging-lib/blob/1.0.4/src/main/java/com/amazon/sqs/javamessaging/message/SQSMessage.java#L1146
    
    See https://docs.aws.amazon.com/AWSSimpleQueueService/latest/SQSDeveloperGuide/sqs-message-attributes.html

commit 09ff0f0713f597c9b22714d843d2f5f5cf259340
Author: Craig Andrews <ca...@...>
Date:   2018-05-11T21:00:23Z

    CAMEL-12507: SQS Producer support for number custom types
    
    If a header of type `Number` is provided, set the dataType to "Number." + an appropriate identifier
    
    These dataType values match those used by amazon-sqs-java-messaging-lib: https://github.com/awslabs/amazon-sqs-java-messaging-lib/blob/1.0.4/src/main/java/com/amazon/sqs/javamessaging/SQSMessagingClientConstants.java#L39
    
    See https://docs.aws.amazon.com/AWSSimpleQueueService/latest/SQSDeveloperGuide/sqs-message-attributes.html

----


> SqsProducer doesn't support Boolean attributes
> ----------------------------------------------
>
>                 Key: CAMEL-12506
>                 URL: https://issues.apache.org/jira/browse/CAMEL-12506
>             Project: Camel
>          Issue Type: Bug
>          Components: camel-aws
>    Affects Versions: 2.20.3, 2.21.0
>            Reporter: Craig
>            Priority: Major
>
> SqsProducer doesn't support Boolean attributes.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)