You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/12/05 05:18:57 UTC
[GitHub] [tvm] merrymercy opened a new pull request #7039: [AutoScheduler] Add tips on resuming the search from a log file
merrymercy opened a new pull request #7039:
URL: https://github.com/apache/tvm/pull/7039
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] merrymercy commented on a change in pull request #7039: [AutoScheduler] Add tips on resuming the search from a log file
Posted by GitBox <gi...@apache.org>.
merrymercy commented on a change in pull request #7039:
URL: https://github.com/apache/tvm/pull/7039#discussion_r536522841
##########
File path: python/tvm/auto_scheduler/task_scheduler.py
##########
@@ -94,8 +94,18 @@ def make_search_policies(
raise ValueError("Invalid search policy: " + search_policy)
if policy_type == "sketch":
+ if load_log_file:
Review comment:
No. This function correctly handles this case and prints
```
SearchPolicy: No measurement records found in XXX.json
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] comaniac commented on a change in pull request #7039: [AutoScheduler] Add tips on resuming the search from a log file
Posted by GitBox <gi...@apache.org>.
comaniac commented on a change in pull request #7039:
URL: https://github.com/apache/tvm/pull/7039#discussion_r536521761
##########
File path: python/tvm/auto_scheduler/task_scheduler.py
##########
@@ -94,8 +94,18 @@ def make_search_policies(
raise ValueError("Invalid search policy: " + search_policy)
if policy_type == "sketch":
+ if load_log_file:
Review comment:
Do we need to check if the log file exists?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi commented on pull request #7039: [AutoScheduler] Add tips on resuming the search from a log file
Posted by GitBox <gi...@apache.org>.
masahi commented on pull request #7039:
URL: https://github.com/apache/tvm/pull/7039#issuecomment-739151006
A new flaky test from topi argwhere https://ci.tlcpack.ai/blue/organizations/jenkins/tvm/detail/PR-7039/1/pipeline
cc @zhiics
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] merrymercy commented on a change in pull request #7039: [AutoScheduler] Add tips on resuming the search from a log file
Posted by GitBox <gi...@apache.org>.
merrymercy commented on a change in pull request #7039:
URL: https://github.com/apache/tvm/pull/7039#discussion_r536890232
##########
File path: python/tvm/auto_scheduler/task_scheduler.py
##########
@@ -94,8 +94,18 @@ def make_search_policies(
raise ValueError("Invalid search policy: " + search_policy)
if policy_type == "sketch":
+ if load_log_file:
+ init_search_callbacks = [PreloadMeasuredStates(load_log_file)]
Review comment:
```suggestion
# use the log file to restore the status of search policies.
init_search_callbacks = [PreloadMeasuredStates(load_log_file)]
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] merrymercy merged pull request #7039: [AutoScheduler] Add tips on resuming the search from a log file
Posted by GitBox <gi...@apache.org>.
merrymercy merged pull request #7039:
URL: https://github.com/apache/tvm/pull/7039
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org