[jira] [Commented] (SPARK-22195) Add cosine similarity to org.apache.spark.ml.linalg.Vectors

["Sean Owen (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SPARK-22195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16190868#comment-16190868 ] 

Sean Owen commented on SPARK-22195:
-----------------------------------

Does this add much? it's just dot(A,B) / (norm(A) * norm(B)), and typically you need to precompute one of the norms anyway (unlikely both)

> Add cosine similarity to org.apache.spark.ml.linalg.Vectors
> -----------------------------------------------------------
>
>                 Key: SPARK-22195
>                 URL: https://issues.apache.org/jira/browse/SPARK-22195
>             Project: Spark
>          Issue Type: New Feature
>          Components: ML
>    Affects Versions: 2.2.0
>            Reporter: yuhao yang
>            Priority: Minor
>
> https://en.wikipedia.org/wiki/Cosine_similarity:
> As the most important measure of similarity, I found it quite useful in some image and NLP applications according to personal experience.
> Suggest to add function for cosine similarity in org.apache.spark.ml.linalg.Vectors.
> Interface:
>   def cosineSimilarity(v1: Vector, v2: Vector): Double = ...
>   def cosineSimilarity(v1: Vector, v2: Vector, norm1: Double, norm2: Double): Double = ...
> Appreciate suggestions and need green light from committers.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org