[GitHub] [kafka] piotrsmolinski opened a new pull request #11707: KAFKA-13607 Fix of the empty values to be treated as if they were absent

[GitBox <gi...@apache.org>]

piotrsmolinski opened a new pull request #11707:
URL: https://github.com/apache/kafka/pull/11707


   Added normalization to the input parameters of the createKeystore and createTruststore
   
   After the change the empty string values of path and passwords are treated as null. The change
   allows the existing entries to be replaced with empty values.
   
   The scenario is when the final configuration of a client (consumer, producer or admin) is defined as a template
   and then refined with specific values. In particular in mTLS configuration the template may specify
   JKS/PKCS12 keystore, but the final configuration uses KIP-651 PEM coded strings.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] kirktrue commented on a change in pull request #11707: KAFKA-13607 Fix of the empty values to be treated as if they were absent

[GitBox <gi...@apache.org>]

kirktrue commented on a change in pull request #11707:
URL: https://github.com/apache/kafka/pull/11707#discussion_r819858996



##########
File path: clients/src/main/java/org/apache/kafka/common/security/ssl/DefaultSslEngineFactory.java
##########
@@ -324,6 +332,22 @@ else if (password != null)
             return null;
     }
 
+    private static String nullify(String string) {

Review comment:
       ```suggestion
       private static String nullify(String string) {
           return Utils.isBlank(string) ? null : string;
       }
   
       private static Password nullify(Password password) {
           return (password == null || nullify(password.value()) == null) ? null : password;
       }
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org