You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by "candiduslynx (via GitHub)" <gi...@apache.org> on 2023/05/08 15:44:26 UTC

[GitHub] [arrow] candiduslynx commented on a diff in pull request #35457: GH-35421: [Go] Ensure interface contract between `array.X.ValueStr` & `array.XBuilder.AppendValueFromString`

candiduslynx commented on code in PR #35457:
URL: https://github.com/apache/arrow/pull/35457#discussion_r1187600184


##########
.gitignore:
##########
@@ -91,4 +91,6 @@ java-native-cpp/
 # archery files
 dev/archery/build
 
-swift/Arrow/.build
\ No newline at end of file
+swift/Arrow/.build
+
+go/vendor

Review Comment:
   I used `go mod vendor` and it introduced a lot of files to stage.
   I presume vendoring the dependencies and committing them into the repo isn't required.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org