You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/05/09 22:52:13 UTC
[GitHub] [maven-release] slawekjaranowski opened a new pull request, #125: [MRELEASE-1091] Use non-interactive mode for forked Maven process
slawekjaranowski opened a new pull request, #125:
URL: https://github.com/apache/maven-release/pull/125
Following this checklist to help us incorporate your
contribution quickly and easily:
- [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MJAVADOC) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line and body.
- [x] Format the pull request title like `[MJAVADOC-XXX] - Fixes bug in ApproximateQuantiles`,
where you replace `MJAVADOC-XXX` with the appropriate JIRA issue. Best practice
is to use the JIRA issue title in the pull request title and in the first line of the
commit message.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Run `mvn clean verify -Prun-its` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [x] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-release] famod commented on pull request #125: [MRELEASE-1091] Use non-interactive mode for forked Maven process
Posted by GitBox <gi...@apache.org>.
famod commented on PR #125:
URL: https://github.com/apache/maven-release/pull/125#issuecomment-1160398620
This change breaks interaction of maven-gpg-plugin with Gpg4win Kleopatra.
Before this change, when gpg-plugin runs, it triggered the cert password prompt windows of Kleopatra but now it fails right away with `no pinentry`.
I don't think this effect is by design?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-release] michael-o commented on pull request #125: [MRELEASE-1091] Use non-interactive mode for forked Maven process
Posted by GitBox <gi...@apache.org>.
michael-o commented on PR #125:
URL: https://github.com/apache/maven-release/pull/125#issuecomment-1160402544
> This change breaks interaction of maven-gpg-plugin with Gpg4win Kleopatra. Before this change, when gpg-plugin runs, it triggered the cert password prompt windows of Kleopatra but now it fails right away with `no pinentry`.
>
> I don't think this effect is by design?
Very good catch. I use Gpg4win Kleopatra as well, but did not move to the new plugin version yet. This is likely the issue:
if ( !isInteractive )
{
cmd.createArg().setValue( "--batch" );
cmd.createArg().setValue( "--no-tty" );
if ( null == passphrase && gpgVersion.isAtLeast( GpgVersion.parse( "2.1" ) ) )
{
// prevent GPG from spawning input prompts in Maven non-interactive mode
cmd.createArg().setValue( "--pinentry-mode" );
cmd.createArg().setValue( "error" );
}
}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-release] michael-o commented on a diff in pull request #125: [MRELEASE-1091] Use non-interactive mode for forked Maven process
Posted by GitBox <gi...@apache.org>.
michael-o commented on code in PR #125:
URL: https://github.com/apache/maven-release/pull/125#discussion_r868822321
##########
maven-release-manager/src/main/java/org/apache/maven/shared/release/exec/InvokerMavenExecutor.java:
##########
@@ -72,16 +72,10 @@ public void executeGoals( File workingDirectory, List<String> goals, ReleaseEnvi
InvocationRequest req = new DefaultInvocationRequest()
.setDebug( getLogger().isDebugEnabled() )
.setBaseDirectory( workingDirectory )
- .setBatchMode( !interactive )
+ .setBatchMode( true ) // MRELEASE-1091
Review Comment:
The comment is redundant, we have git blame
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-release] michael-o commented on pull request #125: [MRELEASE-1091] Use non-interactive mode for forked Maven process
Posted by GitBox <gi...@apache.org>.
michael-o commented on PR #125:
URL: https://github.com/apache/maven-release/pull/125#issuecomment-1160429677
> Hm, I'm not familiar with https://issues.apache.org/jira/browse/MSHARED-1072 but I have never seen that effect in release-plugin. So maybe changing to always non-interactive was too harsh?
Well, to make it properly work from the beginning you need to use `ProcessBuilder` and inherit `stdin` for the forked process in interfactive mode. I consider the Command Executor we have as fucked up since it does not use it and wraps everything in a shell for some pointless reason. I think until this is done cleanly, your usecase must work, if no switch can be toggled for that, we need to revert.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-release] hboutemy commented on pull request #125: [MRELEASE-1091] Use non-interactive mode for forked Maven process
Posted by "hboutemy (via GitHub)" <gi...@apache.org>.
hboutemy commented on PR #125:
URL: https://github.com/apache/maven-release/pull/125#issuecomment-1401414206
was a MRELEASE Jira issue created to track the "breaks interaction of maven-gpg-plugin" issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-release] famod commented on pull request #125: [MRELEASE-1091] Use non-interactive mode for forked Maven process
Posted by GitBox <gi...@apache.org>.
famod commented on PR #125:
URL: https://github.com/apache/maven-release/pull/125#issuecomment-1302613138
@michael-o @slawekjaranowski 3.0.0-M7 still runs into [this](https://github.com/apache/maven-release/pull/125#issuecomment-1160398620) issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-release] famod commented on pull request #125: [MRELEASE-1091] Use non-interactive mode for forked Maven process
Posted by GitBox <gi...@apache.org>.
famod commented on PR #125:
URL: https://github.com/apache/maven-release/pull/125#issuecomment-1160408332
Hm, I'm not familiar with https://issues.apache.org/jira/browse/MSHARED-1072 but I have never seen that effect in release-plugin. So maybe changing to always non-interactive was too harsh?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-release] slawekjaranowski merged pull request #125: [MRELEASE-1091] Use non-interactive mode for forked Maven process
Posted by GitBox <gi...@apache.org>.
slawekjaranowski merged PR #125:
URL: https://github.com/apache/maven-release/pull/125
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-release] slawekjaranowski commented on pull request #125: [MRELEASE-1091] Use non-interactive mode for forked Maven process
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on PR #125:
URL: https://github.com/apache/maven-release/pull/125#issuecomment-1160636178
ok, MSHARED-1072 to fix - I will take care about it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-release] famod commented on pull request #125: [MRELEASE-1091] Use non-interactive mode for forked Maven process
Posted by "famod (via GitHub)" <gi...@apache.org>.
famod commented on PR #125:
URL: https://github.com/apache/maven-release/pull/125#issuecomment-1421478522
@hboutemy
> was a MRELEASE Jira issue https://issues.apache.org/jira/projects/MRELEASE created to track the "breaks interaction of maven-gpg-plugin" issue?
I have just created https://issues.apache.org/jira/browse/MRELEASE-1114
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org