You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Pushkar Raste <pu...@gmail.com> on 2016/02/05 01:30:36 UTC
Review Request 43231: Review request to support size based rolling for
RoleFileSink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43231/
-----------------------------------------------------------
Review request for Flume.
Repository: flume-git
Description
-------
Patch for FLUME-2856. Add size limit based rolling for RollFileSink. Also add support to name files and delete old files. Updates to RollFileSink documentation for using mentioned features.
Diffs
-----
flume-ng-core/src/main/java/org/apache/flume/formatter/output/PathManager.java 933cc94
flume-ng-core/src/main/java/org/apache/flume/sink/RollingFileSink.java 9cb3370
flume-ng-doc/sphinx/FlumeUserGuide.rst 897a2ca
Diff: https://reviews.apache.org/r/43231/diff/
Testing
-------
Thanks,
Pushkar Raste
Re: Review Request 43231: Review request to support size based
rolling for RoleFileSink
Posted by Ralph Goers <rg...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43231/#review118028
-----------------------------------------------------------
I have concerns that this changes the current behavior by now requiring a filename be specified where it wasn't required before, so anyone upgrading will be required to modify their configuration.
- Ralph Goers
On Feb. 5, 2016, 12:30 a.m., Pushkar Raste wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43231/
> -----------------------------------------------------------
>
> (Updated Feb. 5, 2016, 12:30 a.m.)
>
>
> Review request for Flume.
>
>
> Repository: flume-git
>
>
> Description
> -------
>
> Patch for FLUME-2856. Add size limit based rolling for RollFileSink. Also add support to name files and delete old files. Updates to RollFileSink documentation for using mentioned features.
>
>
> Diffs
> -----
>
> flume-ng-core/src/main/java/org/apache/flume/formatter/output/PathManager.java 933cc94
> flume-ng-core/src/main/java/org/apache/flume/sink/RollingFileSink.java 9cb3370
> flume-ng-doc/sphinx/FlumeUserGuide.rst 897a2ca
>
> Diff: https://reviews.apache.org/r/43231/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Pushkar Raste
>
>