You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2020/07/19 11:40:59 UTC

[GitHub] [incubator-echarts] plainheart opened a new pull request #12993: design(#12933): tweak the z value of axisPointer component to make it be displayed under the symbol by default.

plainheart opened a new pull request #12993:
URL: https://github.com/apache/incubator-echarts/pull/12993


   <!-- Please fill in the following information to help us review your PR more efficiently. -->
   
   ## Brief Information
   
   This pull request is in the type of:
   
   - [ ] bug fixing
   - [ ] new feature
   - [x] others
   
   
   
   ### What does this PR do?
   
   <!-- USE ONCE SENTENCE TO DESCRIBE WHAT THIS PR DOES. -->
   Design Changes. Closes #12933 
   
   ### Fixed issues
   
   - #12933
   
   
   ## Details
   
   ### Before: What was the problem?
   
   <!-- DESCRIBE THE BUG OR REQUIREMENT HERE. -->
   The `axisPointer` component displays above the symbol, which may destroy the integrity of the symbol.
   
   <!-- ADD SCREENSHOT HERE IF APPLICABLE. -->
   
   
   
   ### After: How is it fixed in this PR?
   
   <!-- THE RESULT AFTER FIXING AND A SIMPLE EXPLANATION ABOUT HOW IT IS FIXED. -->
   Set the `z` value of `axisPointer` component as a lower value `0` by default.
   
   <!-- ADD SCREENSHOT HERE IF APPLICABLE. -->
   
   
   
   ## Usage
   
   ### Are there any API changes?
   
   - [ ] The API has been changed.
   
   <!-- LIST THE API CHANGES HERE -->
   
   
   
   ### Related test cases or examples to use the new APIs
   
   Any example with the option of `axisPointer`.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [incubator-echarts] pissang commented on pull request #12993: design(#12933): tweak the z value of axisPointer component to make it be displayed under the symbol by default.

Posted by GitBox <gi...@apache.org>.
pissang commented on pull request #12993:
URL: https://github.com/apache/incubator-echarts/pull/12993#issuecomment-660895919


   LGTM, @100pah Can you think of other cases may be broken?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [incubator-echarts] plainheart commented on pull request #12993: design(#12933): tweak the z value of axisPointer component to make it be displayed under the symbol by default.

Posted by GitBox <gi...@apache.org>.
plainheart commented on pull request #12993:
URL: https://github.com/apache/incubator-echarts/pull/12993#issuecomment-660647637


   > I'm thinking if the axisPointer line will be covered by the rectangle from `splitArea` if it's `z` is 0.
   
   I've made a test in `test/axis-splitArea.html` and it seems that the axisPointer won't covered by splitArea.
   
   ![image](https://user-images.githubusercontent.com/26999792/87876510-18569580-ca0b-11ea-846c-e51a2dae04ba.png)
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [incubator-echarts] plainheart commented on pull request #12993: design(#12933): tweak the z value of axisPointer component to make it be displayed under the symbol by default.

Posted by GitBox <gi...@apache.org>.
plainheart commented on pull request #12993:
URL: https://github.com/apache/incubator-echarts/pull/12993#issuecomment-660649926


   Found it may be covered by areaStyle.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [incubator-echarts] echarts-bot[bot] commented on pull request #12993: design(#12933): tweak the z value of axisPointer component to make it be displayed under the symbol by default.

Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #12993:
URL: https://github.com/apache/incubator-echarts/pull/12993#issuecomment-660630862


   Thanks for your contribution!
   The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/incubator-echarts/wiki/How-to-make-a-pull-request).
   
   The pull request is marked to be `PR: author is committer` because you are a committer of this project.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [incubator-echarts] plainheart edited a comment on pull request #12993: design(#12933): tweak the z value of axisPointer component to make it be displayed under the symbol by default.

Posted by GitBox <gi...@apache.org>.
plainheart edited a comment on pull request #12993:
URL: https://github.com/apache/incubator-echarts/pull/12993#issuecomment-660647637


   > I'm thinking if the axisPointer line will be covered by the rectangle from `splitArea` if it's `z` is 0.
   
   I've made a test in `test/axis-splitArea.html` and it seems that the axisPointer won't be covered by splitArea.
   
   ![image](https://user-images.githubusercontent.com/26999792/87876510-18569580-ca0b-11ea-846c-e51a2dae04ba.png)
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [incubator-echarts] pissang commented on pull request #12993: design(#12933): tweak the z value of axisPointer component to make it be displayed under the symbol by default.

Posted by GitBox <gi...@apache.org>.
pissang commented on pull request #12993:
URL: https://github.com/apache/incubator-echarts/pull/12993#issuecomment-660644434


   I'm thinking if the axisPointer line will be covered by the rectangle from `splitArea` if it's `z` is 0.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [incubator-echarts] pissang edited a comment on pull request #12993: design(#12933): tweak the z value of axisPointer component to make it be displayed under the symbol by default.

Posted by GitBox <gi...@apache.org>.
pissang edited a comment on pull request #12993:
URL: https://github.com/apache/incubator-echarts/pull/12993#issuecomment-660895919


   LGTM, @100pah Can you think of other cases that may be broken?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [incubator-echarts] plainheart edited a comment on pull request #12993: design(#12933): tweak the z value of axisPointer component to make it be displayed under the symbol by default.

Posted by GitBox <gi...@apache.org>.
plainheart edited a comment on pull request #12993:
URL: https://github.com/apache/incubator-echarts/pull/12993#issuecomment-660649926


   Found it may be covered by areaStyle.
   
   **After fixing**
   
   ![image](https://user-images.githubusercontent.com/26999792/87879550-1813c580-ca1e-11ea-9d0d-f3c9dbba60ec.png)
   
   ![image](https://user-images.githubusercontent.com/26999792/87879580-632dd880-ca1e-11ea-89fc-48f988a69778.png)
   
   ![image](https://user-images.githubusercontent.com/26999792/87879618-a6884700-ca1e-11ea-9dd4-c64daabc5e84.png)
   
   ![image](https://user-images.githubusercontent.com/26999792/87879710-1991bd80-ca1f-11ea-87e3-288d522a6b26.png)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org