Re: [PR] [incubator-kie-drools-6422] Fix NPE in RuleExecutor.removeDormantTuple [incubator-kie-drools]

["pibizza (via GitHub)" <gi...@apache.org>]

pibizza commented on PR #6631:
URL: https://github.com/apache/incubator-kie-drools/pull/6631#issuecomment-4182577800

   I would suggest reviewing the tests. they seem quite verbose and it really unclear how they relate to the NPE at all. This does not mean that they don't, it means that htey have a lot of details that seem unrelated to the specifics. Why we need for example two different objects in this case? why each object needs three properties? and so on. I am not a superexpert of the code, but I think it would be better to try to simply them and put together the bare minimum that showcases the issue. In which case we can have this NPE? I would suggest reviewing and simplifying the tests before moving on.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org