You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2021/11/19 05:21:35 UTC
[GitHub] [hive] jsoref opened a new pull request #2802: HIVE-24390 Spelling serde
jsoref opened a new pull request #2802:
URL: https://github.com/apache/hive/pull/2802
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/Hive/HowToContribute
2. Ensure that you have created an issue on the Hive project JIRA: https://issues.apache.org/jira/projects/HIVE/summary
3. Ensure you have added or run the appropriate tests for your PR:
4. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]HIVE-XXXXX: Your PR title ...'.
5. Be sure to keep the PR description updated to reflect all changes.
6. Please write your PR title to summarize what this PR proposes.
7. If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This PR corrects misspellings identified by the [check-spelling action](https://github.com/marketplace/actions/check-spelling) in the `serde` directory.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Typos lead to all sorts of problems, branding errors, tests that don't test what's expected, difficulty in understanding both the code and the product.
Landing this would make it possible to add the check-spelling workflow for the `serde/` directory and then slowly land fixes for other directories (while guarding against additional typos in them once a directory's typos have been fixed). See https://github.com/apache/hive/pull/1674#issuecomment-973098911
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description, screenshot and/or a reproducable example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Hive versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No, unless there's a javadoc for `org.apache.hadoop.hive.serde2.RandomTypeUtil. NANOSECONDS_PER_MILLISSECOND` (which is being renamed).
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
The CI does testing (initially https://github.com/jsoref/hive/commit/27ec490bd8e36d2c7b33863ca0e20989fb9f1e62) and the goal is to include it. Initially, I'd like to get these changes merged and then I can provide a PR which just adds the CI (or maybe the CI and a handful of fixes if that many sneak in between now and then).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] kgyrtkirk commented on pull request #2802: HIVE-24390 Spelling serde
Posted by GitBox <gi...@apache.org>.
kgyrtkirk commented on pull request #2802:
URL: https://github.com/apache/hive/pull/2802#issuecomment-976247150
thank you for fixing these things @jsoref!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] jsoref commented on a change in pull request #2802: HIVE-24390 Spelling serde
Posted by GitBox <gi...@apache.org>.
jsoref commented on a change in pull request #2802:
URL: https://github.com/apache/hive/pull/2802#discussion_r753243202
##########
File path: serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryArray.java
##########
@@ -135,9 +135,9 @@ private void parse() {
// adjust arrays
adjustArraySize(arraySize);
// find out the null-bytes
- int arryByteStart = start + vInt.length;
- int nullByteCur = arryByteStart;
- int nullByteEnd = arryByteStart + (arraySize + 7) / 8;
+ int aarryByteStart = start + vInt.length;
+ int nullByteCur = aarryByteStart;
+ int nullByteEnd = aarryByteStart + (arraySize + 7) / 8;
Review comment:
Sigh, I tried to do this manually last n night, not sure how I managed to mangle it so badly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] kgyrtkirk commented on pull request #2802: HIVE-24390 Spelling serde
Posted by GitBox <gi...@apache.org>.
kgyrtkirk commented on pull request #2802:
URL: https://github.com/apache/hive/pull/2802#issuecomment-973982873
this may have a separate ticket HIVE ticket...or should we take some other approach?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] kgyrtkirk commented on pull request #2802: HIVE-24390 Spelling serde
Posted by GitBox <gi...@apache.org>.
kgyrtkirk commented on pull request #2802:
URL: https://github.com/apache/hive/pull/2802#issuecomment-976246984
I think its okay to make these changes under the same jira - while separating the github action to have its own ticket
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] kgyrtkirk commented on a change in pull request #2802: HIVE-24390 Spelling serde
Posted by GitBox <gi...@apache.org>.
kgyrtkirk commented on a change in pull request #2802:
URL: https://github.com/apache/hive/pull/2802#discussion_r753099498
##########
File path: serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryArray.java
##########
@@ -135,9 +135,9 @@ private void parse() {
// adjust arrays
adjustArraySize(arraySize);
// find out the null-bytes
- int arryByteStart = start + vInt.length;
- int nullByteCur = arryByteStart;
- int nullByteEnd = arryByteStart + (arraySize + 7) / 8;
+ int aarryByteStart = start + vInt.length;
+ int nullByteCur = aarryByteStart;
+ int nullByteEnd = aarryByteStart + (arraySize + 7) / 8;
Review comment:
```suggestion
int arrayByteStart = start + vInt.length;
int nullByteCur = arrayByteStart;
int nullByteEnd = arrayByteStart + (arraySize + 7) / 8;
```
##########
File path: serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TimestampLocalTZTypeInfo.java
##########
@@ -45,7 +45,7 @@ public String getTypeName() {
@Override
public void setTypeName(String typeName) {
- // No need to set type name, it should always be timestamplocaltz
+ // No need to set type name, it should always be timestamplocal tz
Review comment:
```suggestion
// No need to set type name, it should always be {@link serdeConstants.TIMESTAMPLOCALTZ_TYPE_NAME}
```
or
```suggestion
// No need to set type name, it should always be TIMESTAMPLOCALTZ_TYPE_NAME
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] kgyrtkirk merged pull request #2802: HIVE-24390 Spelling serde
Posted by GitBox <gi...@apache.org>.
kgyrtkirk merged pull request #2802:
URL: https://github.com/apache/hive/pull/2802
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] jsoref commented on a change in pull request #2802: HIVE-24390 Spelling serde
Posted by GitBox <gi...@apache.org>.
jsoref commented on a change in pull request #2802:
URL: https://github.com/apache/hive/pull/2802#discussion_r753243202
##########
File path: serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryArray.java
##########
@@ -135,9 +135,9 @@ private void parse() {
// adjust arrays
adjustArraySize(arraySize);
// find out the null-bytes
- int arryByteStart = start + vInt.length;
- int nullByteCur = arryByteStart;
- int nullByteEnd = arryByteStart + (arraySize + 7) / 8;
+ int aarryByteStart = start + vInt.length;
+ int nullByteCur = aarryByteStart;
+ int nullByteEnd = aarryByteStart + (arraySize + 7) / 8;
Review comment:
Sigh, I tried to do this manually last night, not sure how I managed to mangle it so badly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] jsoref commented on pull request #2802: HIVE-24390 Spelling serde
Posted by GitBox <gi...@apache.org>.
jsoref commented on pull request #2802:
URL: https://github.com/apache/hive/pull/2802#issuecomment-974125851
Jira ticketing is up to you. If I can avoid filling a new Jira ticket for individual PRs, I'd like to. I'd file a new one for the first instance of landing the action and a new one if there's been a release since the last one so that things don't get too confused, but, otherwise I'd hope not to need to.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org