You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/03/23 14:48:34 UTC
[GitHub] [beam] NomNomGit opened a new pull request #17165: [BEAM-3607] Replacing checkNotNull with checkArgumentNotNull in sdks/java/core
NomNomGit opened a new pull request #17165:
URL: https://github.com/apache/beam/pull/17165
I think doing this for the whole project would be a bit much in one PR. I would create additonal PRs, if this one is okay.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [x] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [x] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #17165: [BEAM-3607] Replacing checkNotNull with checkArgumentNotNull in sdks/java/core
Posted by GitBox <gi...@apache.org>.
kennknowles commented on pull request #17165:
URL: https://github.com/apache/beam/pull/17165#issuecomment-1079505132
Sure thing! But I will be on vacation next week. I will just take a look to make sure these are all the places it should be switched. I do think that probably 100% should be switched, since `checkNotNull` always throws NPE and it looks like the wrong code is blamed for the NPE.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] NomNomGit commented on pull request #17165: [BEAM-3607] Replacing checkNotNull with checkArgumentNotNull in sdks/java/core
Posted by GitBox <gi...@apache.org>.
NomNomGit commented on pull request #17165:
URL: https://github.com/apache/beam/pull/17165#issuecomment-1077495883
@kennknowles may I ask for your review and further guidance here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org