[GitHub] [airflow] kaxil commented on a change in pull request #12354: Fix full_pod_spec for k8spodoperator

[GitBox <gi...@apache.org>]

kaxil commented on a change in pull request #12354:
URL: https://github.com/apache/airflow/pull/12354#discussion_r523281069



##########
File path: airflow/providers/cncf/kubernetes/operators/kubernetes_pod.py
##########
@@ -375,6 +375,10 @@ def create_pod_request_obj(self) -> k8s.V1Pod:
         if self.pod_template_file:
             self.log.debug("Pod template file found, will parse for base pod")
             pod_template = pod_generator.PodGenerator.deserialize_model_file(self.pod_template_file)
+            if self.full_pod_spec:
+                pod_template = PodGenerator.reconcile_pods(pod_template, self.full_pod_spec)
+        elif self.full_pod_spec:
+            pod_template = self.full_pod_spec

Review comment:
       Needs tests




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org